Onboard to RelAPI #842
Onboard to RelAPI #842
Conversation
.github/workflows/release.yml
Outdated
| @@ -52,26 +52,19 @@ jobs: | |||
| name: Install signore | |||
| uses: hashicorp/setup-signore-package@v1 | |||
| - | |||
| uses: hashicorp/setup-hc-releases@v1 | |||
| name: Setup hc-releases | |||
| uses: hashicorp/actions-setup-hc-releases@v1 | |||
There was a problem hiding this comment.
PR is looking great!! Awesome job. Just one note- This will need to point to the v2 tag, which will grab our launch version (0.1.0) of the hc-releases CLI -- being published tmr!
.goreleaser.yml
Outdated
| - HC_RELEASES_KEY={{ .Env.HC_RELEASES_KEY_STAGING }} | ||
| dir: "{{ dir .ArtifactPath }}" | ||
| cmd: | | ||
| hc-releases upload -file={{ .ArtifactName }} -product={{ .ProjectName }} -version={{ .Version }} |
There was a problem hiding this comment.
Before this change, we passed a directory containing all release artifacts to hc-releases, hc-releases uploaded all files from this directory to the S3 bucket.
After the change, we're passing only a single file as an argument to hc-releases. Will this work for a release with multiple files?
There was a problem hiding this comment.
@dbanck after some testing, we've changed it from-file={{ .ArtifactName }} to -file={{ .ArtifactPath }} to allow multiple files.
.goreleaser.yml
Outdated
| @@ -110,16 +110,14 @@ brews: | |||
| system "#{bin}/terraform-ls --version" | |||
|
|
|||
| publishers: | |||
| - name: "hc-releases" | |||
| - name: upload | |||
There was a problem hiding this comment.
| - name: upload | |
| - name: "hc-releases" |
I think in the context of GoRelaser config, the original name is still relevant?
| version: ${{ github.ref_name }} | ||
| hc-releases-host: ${{ secrets.HC_RELEASES_HOST_PROD }} | ||
| hc-releases-key: ${{ secrets.HC_RELEASES_KEY_PROD }} | ||
| hc-releases-source_env_key: ${{ secrets.HC_RELEASES_KEY_STAGING }} |
There was a problem hiding this comment.
Do we need to replace all these *_STAGING references with *_PROD? 🤔
There was a problem hiding this comment.
HC_RELEASES_KEY_STAGING is correct in this context as the hc-releases promote command (which we are running in the action) requires the API key of the source environment in order to promote.
|
@radeksimko - I think we are good to go now 🤞 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Onboard project to the Releases API.
Note: RelEng will merge this PR when ready