Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode module calls (for uninitialized modules) #900

Merged
merged 5 commits into from
May 9, 2022
Merged

Decode module calls (for uninitialized modules) #900

merged 5 commits into from
May 9, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Apr 28, 2022 •
edited by radeksimko
Loading

Depends on:

This PR makes use of the new early decoded module calls introduced in hashicorp/terraform-schema#106. We save those in state.ModuleMetadata and use them only in ModuleStore.ModuleCalls() for now.

Since ModuleStore.ModuleCalls() is only used within the watcher, which then requires access to the moduleCall.Path, the early decoded modules don't do much, since they're missing the path. But the upcoming features will make better use of that.

Closes #882

@dbanck dbanck added enhancement New feature or request modules Functionality related to the module block and modules generally labels Apr 28, 2022
@dbanck dbanck added this to the v0.28.0 milestone Apr 28, 2022
@dbanck dbanck self-assigned this Apr 28, 2022
@dbanck dbanck force-pushed the f-decode-module-calls branch 2 times, most recently from 6b2c3b2 to 802c250 Compare April 28, 2022 18:18
dbanck
dbanck commented Apr 28, 2022
View reviewed changes
internal/state/module.go Outdated Show resolved Hide resolved
@radeksimko radeksimko assigned radeksimko and unassigned dbanck May 3, 2022
dbanck added 3 commits May 4, 2022 17:44
@dbanck @radeksimko
Bump terraform-schema to 49d5d60
6ff4c63
@dbanck @radeksimko
Add ModuleCalls to state.ModuleMetadata
593c0a8
@dbanck @radeksimko
Update ModuleStore.ModuleCalls to make use of the earlydecoder module…
b3d6ada 
…Calls

If we have a manifest/installed modules we still return those first,
because they have a resolved path we can use to index the module.
@radeksimko radeksimko force-pushed the f-decode-module-calls branch from 802c250 to 4daf665 Compare May 5, 2022 20:05
@radeksimko radeksimko mentioned this pull request May 5, 2022
Merged
@radeksimko radeksimko marked this pull request as ready for review May 5, 2022 20:08
@radeksimko radeksimko requested a review from a team as a code owner May 5, 2022 20:08
@radeksimko radeksimko force-pushed the f-decode-module-calls branch from 4daf665 to 5ef8bee Compare May 9, 2022 12:46
@radeksimko radeksimko merged commit 555e333 into main May 9, 2022
@radeksimko radeksimko deleted the f-decode-module-calls branch May 9, 2022 15:04
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko left review comments

@jpogran jpogran jpogran approved these changes

Assignees

@radeksimko radeksimko

Labels
enhancement New feature or request modules Functionality related to the module block and modules generally
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.

module metadata: Decode module calls (for uninitialized modules)
3 participants
@dbanck @jpogran @radeksimko