Subscribe to updates of module.calls data #909
Conversation
Adds support for a client to register a command that will refresh clide side data based on changes the server has detected in the workspace. This specifically adds a new command to refresh the module calls shown client side. The existing Module hook system is used to detect changes in the workspace and notify the client that data has changed.
Co-authored-by: Radek Simko <radek.simko@gmail.com>
There was a problem hiding this comment.
Works great!
I did notice the effect of hashicorp/terraform#30005 while testing this, but adding a new module & init worked great. We can avoid that upstream issue probably entirely as part of #725
docs/commands.md
Outdated
| @@ -184,3 +184,53 @@ installed version. | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| # Client Side Commands | |||
There was a problem hiding this comment.
I didn't realize when we were discussing this on Slack that you meant implementation notes for LS maintainers - apologies! You were right that this isn't the best place as this is primarily for client-side maintainers. 😄
We don't have any content for server maintainers yet, aside from the architecture doc. Would you mind copying this into a new one then? You can probably link it from the architecture doc.
We could call it language-server.md, to align the name with https://github.com/hashicorp/terraform-ls/blob/main/docs/language-clients.md
There was a problem hiding this comment.
That said I think that some brief docs for client maintainers would be still helpful here, perhaps 1 section to describe the refresh mechanism in general and/or mention of the relevant capability under each relevant command.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds support for a client to register a command that will refresh clide side data based on changes the server has detected in the workspace.
This specifically adds a new command to refresh the module calls shown client side. The existing Module hook system is used to detect changes in the workspace and notify the client that data has changed.