Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utm parameters to module.* commands #923

Merged
merged 3 commits into from
May 31, 2022
Merged

Add utm parameters to module.* commands #923

merged 3 commits into from
May 31, 2022

Conversation

radeksimko
Copy link
Member

Closes #911

Before

2022/05/20 12:41:18 rpc_logger.go:29: Incoming request for "workspace/executeCommand" (ID 15): {"command":"terraform-ls.module.providers","arguments":["uri=file:///private/var/workspace/tf-test"]}
2022/05/20 12:41:18 rpc_logger.go:50: Response to "workspace/executeCommand" (ID 15): {"v":0,"provider_requirements":{"registry.terraform.io/hashicorp/aws":{"display_name":"hashicorp/aws","docs_link":"https://registry.terraform.io/providers/hashicorp/aws/latest"}},"installed_providers":{"registry.terraform.io/hashicorp/aws":"4.14.0"}}
2022/05/20 12:41:18 rpc_logger.go:29: Incoming request for "workspace/executeCommand" (ID 16): {"command":"terraform-ls.module.calls","arguments":["uri=file:///private/var/workspace/tf-test"]}
2022/05/20 12:41:18 rpc_logger.go:50: Response to "workspace/executeCommand" (ID 16): {"v":0,"module_calls":[{"name":"vpc","source_addr":"registry.terraform.io/terraform-aws-modules/vpc/aws","version":"3.14.0","source_type":"tfregistry","docs_link":"https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws/3.14.0","dependent_modules":[]}]}

After

2022/05/20 12:39:16 rpc_logger.go:29: Incoming request for "workspace/executeCommand" (ID 125): {"command":"terraform-ls.module.providers","arguments":["uri=file:///private/var/workspace/tf-test"]}
2022/05/20 12:39:16 rpc_logger.go:50: Response to "workspace/executeCommand" (ID 125): {"v":0,"provider_requirements":{"registry.terraform.io/hashicorp/aws":{"display_name":"hashicorp/aws","docs_link":"https://registry.terraform.io/providers/hashicorp/aws/latest?utm_content=workspace%2FexecuteCommand%2Fmodule.providers\u0026utm_medium=Visual+Studio+Code\u0026utm_source=terraform-ls"}},"installed_providers":{"registry.terraform.io/hashicorp/aws":"4.14.0"}}
2022/05/20 12:39:16 rpc_logger.go:29: Incoming request for "workspace/executeCommand" (ID 126): {"command":"terraform-ls.module.calls","arguments":["uri=file:///private/var/workspace/tf-test"]}
2022/05/20 12:39:16 rpc_logger.go:50: Response to "workspace/executeCommand" (ID 126): {"v":0,"module_calls":[{"name":"vpc","source_addr":"registry.terraform.io/terraform-aws-modules/vpc/aws","version":"3.14.0","source_type":"tfregistry","docs_link":"https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws/3.14.0?utm_content=workspace%2FexecuteCommand%2Fmodule.calls\u0026utm_medium=Visual+Studio+Code\u0026utm_source=terraform-ls","dependent_modules":[]}]}

@radeksimko radeksimko added the enhancement New feature or request label May 20, 2022
@radeksimko radeksimko requested a review from a team as a code owner May 20, 2022 11:42
@radeksimko radeksimko added this to the v0.28.0 milestone May 20, 2022
@radeksimko radeksimko requested a review from jpogran May 27, 2022 14:04
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@radeksimko radeksimko merged commit ba5501c into main May 31, 2022
@radeksimko radeksimko deleted the f-add-utm-params branch May 31, 2022 13:16
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add utm query parameters to docs links in module.calls and module.providers
2 participants