Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: allow version metadata to be set #945

Merged
merged 1 commit into from
Jun 10, 2022
Merged

main: allow version metadata to be set #945

merged 1 commit into from
Jun 10, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 9, 2022

This allows us - or more importantly anyone other than us - to set build metadata when building LS.

In particular this allows us to update the community Homebrew formula to help more easily distinguish LS installed from the Homebrew community tap from our own builds - which can be useful when troubleshooting - see e.g. #944 (comment)

https://github.com/Homebrew/homebrew-core/blob/dc4bba37bc14ca0a7796656638d6f4df86cc3e0d/Formula/oras.rb#L21-L25

How to test

go build -ldflags="-s -w -X main.version=0.1.0 -X main.versionMeta=homebrew"
./terraform-ls version
0.1.0-dev+homebrew
platform: darwin/arm64
go: go1.18.2
compiler: gc
./terraform-ls version -json
{
  "version": "0.1.0-dev+homebrew",
  "go": "go1.18.2",
  "os": "darwin",
  "arch": "arm64",
  "compiler": "gc"
}

@radeksimko radeksimko added the enhancement New feature or request label Jun 9, 2022
@radeksimko radeksimko marked this pull request as ready for review June 9, 2022 14:34
@radeksimko radeksimko requested a review from a team as a code owner June 9, 2022 14:34
@radeksimko radeksimko self-assigned this Jun 9, 2022
@radeksimko radeksimko modified the milestones: v0.29.0, v0.28.2 Jun 9, 2022
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@radeksimko radeksimko merged commit b7a39bd into main Jun 10, 2022
@radeksimko radeksimko deleted the f-version-meta branch June 10, 2022 18:10
@radeksimko radeksimko modified the milestones: v0.28.2, v0.29.0 Jun 17, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants