Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal watcher with LSP's watching mechanism #953

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Replace internal watcher with LSP's watching mechanism #953

merged 2 commits into from
Jun 17, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 14, 2022 •
edited
Loading

Fixes #867

How to test this

I added two E2E tests confirming both provider schema & module manifest refresh is working. The previous watcher didn't have any tests (since mocking fsnotify events was not trivial).

One can also check the module & provider views in the VS Code extension as they update automatically after terraform init:

Screen.Recording.2022-06-16.at.12.40.59.mov

@radeksimko radeksimko added the enhancement New feature or request label Jun 14, 2022
@radeksimko radeksimko added this to the v0.29.0 milestone Jun 14, 2022
@radeksimko radeksimko force-pushed the f-lsp-file-watching branch 4 times, most recently from 66e2bca to 274657e Compare June 16, 2022 09:18
@radeksimko radeksimko force-pushed the f-lsp-file-watching branch from 274657e to 3640586 Compare June 16, 2022 11:36
@radeksimko radeksimko marked this pull request as ready for review June 16, 2022 11:36
@radeksimko radeksimko requested a review from a team as a code owner June 16, 2022 11:36
@radeksimko radeksimko mentioned this pull request Jun 16, 2022
Closed
jpogran
jpogran approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a lot faster in my local testing!

@radeksimko radeksimko merged commit 9fcc1c9 into main Jun 17, 2022
@radeksimko radeksimko deleted the f-lsp-file-watching branch June 17, 2022 15:09
@radeksimko radeksimko mentioned this pull request Jun 28, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging this pull request may close these issues.

Replace internal watcher with LSP's DidChangeWatchedFilesRegistrationOptions
2 participants
@radeksimko @jpogran