refactor: Decouple walker & indexing logic #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-walker-refactoring
branch
2 times, most recently
from
e75a715 to
ac1ba77
Compare
This refactoring solves two problems: - reduce dependencies of the walker and make it focused on _walking_ by moving out the indexing logic - move all indexing logic to a new dedicated indexer package, so that it’s easier deduplicate and reuse code within the package
radeksimko
force-pushed
the
f-walker-refactoring
branch
from
ac1ba77 to
5d6103c
Compare
radeksimko
force-pushed
the
f-walker-refactoring
branch
from
b4d386b to
11c70d8
Compare
dbanck
approved these changes
Jul 1, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #881
This refactoring solves two problems:
I moved most of the indexing logic pretty much as-is to avoid more noise in already big PR. I assume that we can do more factoring later in a separate PR.
I did consider adding tests to the new
indexerpackage, but then decided against it until it's refactored, and also because it's already being tested anyway as part ofdidOpen,didChange,didChangeWatchedFileshandlers andwalkerpackage.