Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output relative paths for migrate code template references #330

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Jan 24, 2024

Closes: #326

Changes the code templates references to use relative paths (relative to provider directory) from absolute paths.

@SBGoods SBGoods requested a review from a team as a code owner January 24, 2024 18:12
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 (also suggest PR labels and milestone assignment for future travelers as a good practice)

@SBGoods SBGoods added command/migrate bug Something isn't working labels Jan 24, 2024
@SBGoods SBGoods added this to the v0.19.0 milestone Jan 24, 2024
@SBGoods SBGoods merged commit 6d1472f into main Jan 24, 2024
6 checks passed
@SBGoods SBGoods deleted the SBGoods/migrate-relative-paths branch January 24, 2024 22:02
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working command/migrate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfplugindocs migrate command outputs absolute file paths
2 participants