-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added write-only support to generate #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes here look good! Two general comments to consider:
- We'll want to add a callout somewhere on the markdown page, like
-> Write-only attributes are supported in Terraform 1.11 and later.
(we already started a thread offline about it) - We'll want a changelog for this new functionality!
Co-authored-by: Austin Valle <austinvalle@gmail.com>
Added the changelog but decided maybe we should just merge this PR and later add the link to write-only docs when it is available and the render logic for printing out that it is only supported in Terraform 1.11 in a different PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... but decided maybe we should just merge this PR and later add the link to write-only docs when it is available and the render logic for printing out that it is only supported in Terraform 1.11 in a different PR.
Yeah if you want to open a separate PR for that before we release v0.21.0
of plugin-docs, sounds good to me! 🚀
For the
generate
command, updated the render logic using terraform-json to addWriteOnly
.For an example JSON Attribute:
We get the following md: