Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID attribute marked as Optional in generated documentation #45

Closed
nmuesch opened this issue Mar 4, 2021 · 4 comments
Closed

ID attribute marked as Optional in generated documentation #45

nmuesch opened this issue Mar 4, 2021 · 4 comments
Assignees

Comments

@nmuesch
Copy link
Contributor

nmuesch commented Mar 4, 2021

Each terraform schema has an implicit ID that needs to be set for the terraform lifecycle to work properly.
We don't set this "ID" explicitly in the schema, but the generated documentation seems to mark it as Optional

I think this should be marked as "Read Only" if the "ID" isn't explicitly in the schema by the provider developer.

Example Dashboard Resource Schema - https://github.com/DataDog/terraform-provider-datadog/blob/master/datadog/resource_datadog_dashboard.go#L44
Generated Documentation - https://registry.terraform.io/providers/DataDog/datadog/latest/docs/resources/dashboard#optional

@OJFord
Copy link
Contributor

OJFord commented May 3, 2022

Can be closed, thanks to #134 & v0.8.0 🙂

(Cc @detro)

@detro
Copy link
Contributor

detro commented May 31, 2022

Yea, this can be closed.
I missed it in my search.

@detro
Copy link
Contributor

detro commented May 31, 2022

Closed by #134

@detro detro closed this as completed May 31, 2022
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants