Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Migrate implementations to support terraform-plugin-framework version 0.17.0 #80

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 25, 2022

The next terraform-plugin-framework version will have separate datasource/schema, provider/schema, and resource/schema packages which use the type-specific schema/validator interfaces. This change updates all schema-based validators to the new interfaces. In the cases where the validators did not match a single type (e.g. metavalidator, schemavalidator package validators), those validators are now present in all the type-specific validator packages.

…rsion 0.17.0

The next terraform-plugin-framework version will have separate `datasource/schema`, `provider/schema`, and `resource/schema` packages which use the type-specific `schema/validator` interfaces. This change updates all schema-based validators to the new interfaces. In the cases where the validators did not match a single type (e.g. `metavalidator`, `schemavalidator` package validators), those validators are now present in all the type-specific validator packages.
@bflad bflad requested a review from a team as a code owner November 25, 2022 22:48
@bflad
Copy link
Contributor Author

bflad commented Nov 25, 2022

This requires hashicorp/terraform-plugin-framework#546. Local testing before release can be done via checking out that branch and running:

go work init
go use .
go work edit -replace=github.com/hashicorp/terraform-plugin-framework=/path/to/framework
go test -count=1 ./...

Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v0.7.0 milestone Nov 30, 2022
@bflad bflad merged commit 8928062 into main Nov 30, 2022
@bflad bflad deleted the bflad/type-specific-validator-interfaces branch November 30, 2022 20:05
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants