types: Support Float64, Float64Type, Int64, and Int64Type

[bflad]

Closes #137

[paddycarver]

I'd say let's still bubble up the error anyways, for when things don't work the way they're supposed to. Error checking in depth. :)

[bflad]

You got it!

[bflad]

Ah, I'm not positive of this, but an interesting caveat to this is that this error I think will always be returned first instead of the Validate() diagnostics. I guess the only real difference is the error messaging/formatting, but could be something to consider.

[paddycarver]

Will it? I thought we designed Validate diagnostics to run before trying to create any attr.Values, which is (as far as I can tell) where this gets used? Otherwise, the Validate would take an attr.Value argument, I think?

[paddycarver]

terraform-plugin-framework/tfsdk/config.go

Lines 46 to 73 in 84afb9a

	tfValue, err := c.terraformValueAtPath(path)
	if err != nil {
	diags.AddAttributeError(
	path,
	"Configuration Read Error",
	"An unexpected error was encountered trying to read an attribute from the configuration. This is always an error in the provider. Please report the following to the provider developer:\n\n"+err.Error(),
	)
	return nil, diags
	}
	if attrTypeWithValidate, ok := attrType.(attr.TypeWithValidate); ok {
	diags.Append(attrTypeWithValidate.Validate(ctx, tfValue, path)...)
	if diags.HasError() {
	return nil, diags
	}
	}
	attrValue, err := attrType.ValueFromTerraform(ctx, tfValue)
	if err != nil {
	diags.AddAttributeError(
	path,
	"Configuration Read Error",
	"An unexpected error was encountered trying to read an attribute from the configuration. This is always an error in the provider. Please report the following to the provider developer:\n\n"+err.Error(),
	)
	return nil, diags
	}

This seems to suggest to me, for GetAttribute on Config specifically at least, that the Validate diags will be returned instead of the ValueFromTerraform error when both are returned. I think the reason I'm arguing we should handle it here anyways is as a safeguard in case we ever forget to call Validate or call them in the wrong order or something.

[paddycarver]

LGTM 👍 🚀

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.