Introduce some logging. #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
force-pushed
the
paddy_logging
branch
from
79ab6bb to
a0393d2
Compare
bflad
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
This looks good to me -- using this branch with terraform-provider-corner acceptance testing is nicely populating the logs and receiving the terraform-plugin-go contextual information. We can adjust this as necessary going forward, but this is a good first iteration. 🚀
2021-12-13T14:18:10.598-0500 [TRACE] GRPCProvider.v6: ValidateResourceConfig
2021-12-13T14:18:10.598-0500 [TRACE] sdk.proto: Received request: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=c51464da-de24-368d-18a9-d35d46a62795 tf_resource_type=framework_user tf_rpc=ValidateResourceConfig
2021-12-13T14:18:10.598-0500 [TRACE] sdk.proto: Calling downstream: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=c51464da-de24-368d-18a9-d35d46a62795 tf_resource_type=framework_user tf_rpc=ValidateResourceConfig
2021-12-13T14:18:10.598-0500 [TRACE] sdk.proto: Called downstream: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=c51464da-de24-368d-18a9-d35d46a62795 tf_resource_type=framework_user tf_rpc=ValidateResourceConfig
2021-12-13T14:18:10.598-0500 [TRACE] sdk.proto: Served request: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=c51464da-de24-368d-18a9-d35d46a62795 tf_resource_type=framework_user tf_rpc=ValidateResourceConfig
2021-12-13T14:18:10.598-0500 [TRACE] GRPCProvider.v6: PlanResourceChange
2021-12-13T14:18:10.599-0500 [TRACE] sdk.proto: Received request: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange
2021-12-13T14:18:10.599-0500 [TRACE] sdk.proto: Calling downstream: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange
2021-12-13T14:18:10.599-0500 [TRACE] sdk: marking computed null values as unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange
2021-12-13T14:18:10.599-0500 [DEBUG] sdk: marking computed attribute that is null in the config as unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange path=AttributeName("date_joined")
2021-12-13T14:18:10.599-0500 [TRACE] sdk: attribute not null in config, not marking unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange path=AttributeName("email")
2021-12-13T14:18:10.599-0500 [TRACE] sdk: attribute not null in config, not marking unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange path=AttributeName("id")
2021-12-13T14:18:10.599-0500 [DEBUG] sdk: marking computed attribute that is null in the config as unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange path=AttributeName("language")
2021-12-13T14:18:10.599-0500 [TRACE] sdk: attribute not null in config, not marking unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange path=AttributeName("name")
2021-12-13T14:18:10.599-0500 [TRACE] sdk: attribute not null in config, not marking unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange path=AttributeName("age")
2021-12-13T14:18:10.599-0500 [TRACE] sdk: at least one value was changed to unknown: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange
2021-12-13T14:18:10.599-0500 [TRACE] sdk.proto: Called downstream: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange
2021-12-13T14:18:10.599-0500 [TRACE] sdk.proto: Served request: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=23f980b6-6bc0-8950-0072-1d985a917858 tf_resource_type=framework_user tf_rpc=PlanResourceChange
2021-12-13T14:18:10.599-0500 [TRACE] checkPlannedChange: Verifying that actual change (action Create) matches planned change (action Create)
2021-12-13T14:18:10.599-0500 [TRACE] readResourceInstanceState: reading state for framework_user.foo
2021-12-13T14:18:10.599-0500 [TRACE] readResourceInstanceState: no state present for framework_user.foo
2021-12-13T14:18:10.599-0500 [INFO] Starting apply for framework_user.foo
2021-12-13T14:18:10.599-0500 [DEBUG] framework_user.foo: applying the planned Create change
2021-12-13T14:18:10.599-0500 [TRACE] GRPCProvider.v6: ApplyResourceChange
2021-12-13T14:18:10.600-0500 [TRACE] sdk.proto: Received request: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=2440e8c7-a199-c759-b6a9-5e6f6b48dc1e tf_resource_type=framework_user tf_rpc=ApplyResourceChange
2021-12-13T14:18:10.600-0500 [TRACE] sdk.proto: Calling downstream: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=2440e8c7-a199-c759-b6a9-5e6f6b48dc1e tf_resource_type=framework_user tf_rpc=ApplyResourceChange
2021-12-13T14:18:10.600-0500 [TRACE] sdk: running create: tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=2440e8c7-a199-c759-b6a9-5e6f6b48dc1e tf_resource_type=framework_user tf_rpc=ApplyResourceChange
2021-12-13T14:18:10.600-0500 [TRACE] sdk.proto: Called downstream: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=2440e8c7-a199-c759-b6a9-5e6f6b48dc1e tf_resource_type=framework_user tf_rpc=ApplyResourceChange
2021-12-13T14:18:10.600-0500 [TRACE] sdk.proto: Served request: tf_proto_version=6 tf_provider_addr=registry.terraform.io/hashicorp/framework tf_req_id=2440e8c7-a199-c759-b6a9-5e6f6b48dc1e tf_resource_type=framework_user tf_rpc=ApplyResourceChange
Start logging using tflog. This largely just inserts logging at decision points in the serve.go file of tfsdk, which is where the most invisible, impactful decisions are made. Over time, logging should be introduced in more places on an as-needed basis or as we touch those parts of the code. Fixes #63.
paddycarver
force-pushed
the
paddy_logging
branch
from
a0393d2 to
2fc6513
Compare
|
Happy with that changelog? |
bflad
approved these changes
Dec 13, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start logging using tflog. This largely just inserts logging at decision
points in the serve.go file of tfsdk, which is where the most invisible,
impactful decisions are made. Over time, logging should be introduced in
more places on an as-needed basis or as we touch those parts of the
code.
Fixes #63.