meta package #37
meta package #37
Conversation
There was a problem hiding this comment.
Overall looking great! Only thing I question is if the meta package is responsible for many meta things, should these variables and functions be prefixed with SDK like SDKVersion (eyesore I know). I envision we might query the protocol for protocol versions? Not a blocker for me just thought I would bring it up.
There was a problem hiding this comment.
Totally nitpicky note & not a blocker, but we may want to think about the UA string length. I'm not sure what is considered reasonable and if we could reduce it e.g. by assuming that "Plugin SDK" is Terraform's SDK, or if we need/should be explicit in each UA "product" name.
We just need to keep in mind that providers will want to append things like AWS' SDK version, Go version, arch, os etc.
Just food for thought. Feel free to merge though!
|
I think we should be explicit in each UA product name, as the relationship between product names is not represented in the RFC7231 syntax, although there is some argument to be made that our product identifiers are not "listed in decreasing order of their significance". With the addition of the extra details you mention, UA headers produced by provider requests should still not hit 200 characters, which I think is a reasonable lower bound for incompatibility with very old or very quirky web servers. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
No description provided.