Set default TerraformVersion #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Configure implementation if unset
radeksimko
approved these changes
Sep 27, 2019
|
I believe we decided to leave this unset for older versions so that in principle the provider could differentiate an unknown version from a known one, but this special sigil value that would never be generated by a real version of Terraform can serve that purpose too, as long as all the consumers know that if they see this string it could be Terraform 0.10. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the provider is served over the 0.12 protocol it will have a
TerraformVersionset. If it is serving the old protocol it will be unset. This is to avoid a piece of boilerplate from repeating over and over in providerConfigureFuncs, and ensure a consistent special designation of0.11+compatible, implying it was TF 0.10/0.11 (0.11 compatible/protocol 4).I originally wanted to try and set this up in the protocol 4 parts of the code... but I couldn't track it down and plumbing it through might be a pain. The risk with this implementation is it feels awkward to mutate the provider struct at this point, are we sure we never want to access this variable before
Configureis invoked? I'm not a lifecycle/architecture expert yet.