testing.T.Helper() not called in defered functions

[ewbankkit]

terraform-plugin-testing version

% go list -m github.com/hashicorp/terraform-plugin-testing/...
github.com/hashicorp/terraform-plugin-testing v1.6.0

Actual Behavior

...
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: ...

terraform-plugin-testing/helper/resource/testing_new.go

Line 91 in 058bbd4

t.Fatalf("Error running post-test destroy, there may be dangling resources: %s", err.Error())

This is in a function that is defered. The outer function does call testing.T.Helper(), but it is not called in the inner (defered function).

Expected Behavior

The file and line number reported should be from the calling test case.

[bflad]

Thank you for raising this, @ewbankkit 👍 This seems very reasonable, especially given that if we were likely to rewrite the internals of the testing logic, it would probably pass error types directly, rather than testing.T, which would prevent this sort of issue. If you are willing to submit a pull request for this change, we would be happy to review it.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.