From 304da9fdece4954f619625b7823fa7ad3346125e Mon Sep 17 00:00:00 2001
From: sh0e1 <sh0e1@users.noreply.github.com>
Date: Tue, 25 Jul 2023 01:24:45 +0900
Subject: [PATCH] r/aws_lightsail_domain_entry: support for AAAA record type

---
 internal/service/lightsail/domain_entry.go    |  1 +
 .../service/lightsail/domain_entry_test.go    | 55 +++++++++++++++++++
 2 files changed, 56 insertions(+)

diff --git a/internal/service/lightsail/domain_entry.go b/internal/service/lightsail/domain_entry.go
index f38a2dbd2db6..feda09072f82 100644
--- a/internal/service/lightsail/domain_entry.go
+++ b/internal/service/lightsail/domain_entry.go
@@ -65,6 +65,7 @@ func ResourceDomainEntry() *schema.Resource {
 				Required: true,
 				ValidateFunc: validation.StringInSlice([]string{
 					"A",
+					"AAAA",
 					"CNAME",
 					"MX",
 					"NS",
diff --git a/internal/service/lightsail/domain_entry_test.go b/internal/service/lightsail/domain_entry_test.go
index 1f66999ce8a4..cb0882765b1e 100644
--- a/internal/service/lightsail/domain_entry_test.go
+++ b/internal/service/lightsail/domain_entry_test.go
@@ -167,6 +167,46 @@ func TestAccLightsailDomainEntry_disappears(t *testing.T) {
 	})
 }
 
+func TestAccLightsailDomainEntry_typeAAAA(t *testing.T) {
+	ctx := acctest.Context(t)
+	resourceName := "aws_lightsail_domain_entry.test"
+	domainName := acctest.RandomDomainName()
+	domainEntryName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.PreCheck(ctx, t); acctest.PreCheckRegion(t, string(types.RegionNameUsEast1)) },
+		ErrorCheck:               acctest.ErrorCheck(t, strings.ToLower(lightsail.ServiceID)),
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
+		CheckDestroy:             testAccCheckDomainEntryDestroy(ctx),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDomainEntryConfig_typeAAAA(domainName, domainEntryName),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					testAccCheckDomainEntryExists(ctx, resourceName),
+					resource.TestCheckResourceAttr(resourceName, "domain_name", domainName),
+					resource.TestCheckResourceAttr(resourceName, "name", domainEntryName),
+					resource.TestCheckResourceAttr(resourceName, "target", "::1"),
+					resource.TestCheckResourceAttr(resourceName, "type", "AAAA"),
+				),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+			// Validate that we can import an existing resource using the legacy separator
+			// Validate that the ID is updated to use the new common separator
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateIdFunc: testAccDomainEntryStateLegacyIdFunc(resourceName),
+				ImportStateVerify: true,
+				Check:             resource.TestCheckResourceAttr(resourceName, "id", fmt.Sprintf("%s,%s,%s,%s", domainEntryName, domainName, "AAAA", "::1")),
+			},
+		},
+	})
+}
+
 func testAccCheckDomainEntryExists(ctx context.Context, n string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]
@@ -236,6 +276,21 @@ resource "aws_lightsail_domain_entry" "test" {
 `, domainName, domainEntryName)
 }
 
+func testAccDomainEntryConfig_typeAAAA(domainName string, domainEntryName string) string {
+	return fmt.Sprintf(`
+resource "aws_lightsail_domain" "test" {
+  domain_name = %[1]q
+}
+
+resource "aws_lightsail_domain_entry" "test" {
+  domain_name = aws_lightsail_domain.test.id
+  name        = %[2]q
+  type        = "AAAA"
+  target      = "::1"
+}
+`, domainName, domainEntryName)
+}
+
 func testAccDomainEntryStateLegacyIdFunc(resourceName string) resource.ImportStateIdFunc {
 	return func(s *terraform.State) (string, error) {
 		rs, ok := s.RootModule().Resources[resourceName]