diff --git a/aws/resource_aws_db_instance.go b/aws/resource_aws_db_instance.go index ce115ae3f43..d3be465656f 100644 --- a/aws/resource_aws_db_instance.go +++ b/aws/resource_aws_db_instance.go @@ -1470,7 +1470,8 @@ func resourceAwsDbInstanceUpdate(d *schema.ResourceData, meta interface{}) error if d.HasChange("allow_major_version_upgrade") { d.SetPartial("allow_major_version_upgrade") req.AllowMajorVersionUpgrade = aws.Bool(d.Get("allow_major_version_upgrade").(bool)) - requestUpdate = true + // Having allowing_major_version_upgrade by itself should not trigger ModifyDBInstance + // as it results in InvalidParameterCombination: No modifications were requested } if d.HasChange("backup_retention_period") { d.SetPartial("backup_retention_period") diff --git a/aws/resource_aws_db_instance_test.go b/aws/resource_aws_db_instance_test.go index 3cd8d32526d..6b535431d12 100644 --- a/aws/resource_aws_db_instance_test.go +++ b/aws/resource_aws_db_instance_test.go @@ -293,6 +293,13 @@ func TestAccAWSDBInstance_AllowMajorVersionUpgrade(t *testing.T) { "skip_final_snapshot", }, }, + { + Config: testAccAWSDBInstanceConfigAllowMajorVersionUpgrade(rName, false), + Check: resource.ComposeTestCheckFunc( + testAccCheckAWSDBInstanceExists(resourceName, &dbInstance1), + resource.TestCheckResourceAttr(resourceName, "allow_major_version_upgrade", "false"), + ), + }, }, }) }