Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Require https" on elasticsearch #10424

Closed
alexisde opened this issue Oct 8, 2019 · 3 comments · Fixed by #10430
Closed

Support "Require https" on elasticsearch #10424

alexisde opened this issue Oct 8, 2019 · 3 comments · Fixed by #10430
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.
Milestone

Comments

@alexisde
Copy link

alexisde commented Oct 8, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

AWS announced support for https required on elasticsearch domains, Would it be possible to implement?

https://aws.amazon.com/about-aws/whats-new/2019/10/amazon-elasticsearch-service-provides-option-to-mandate-https/?ck_subscriber_id=512831964

Add require_https argument to elasticsearch resources

  • aws_elasticsearch

Potential Terraform Configuration

resource "aws_elasticsearch_domain" "example" {
  domain_name           = "example"
  elasticsearch_version = "1.5"
  require_https = true

  cluster_config {
    instance_type = "r4.large.elasticsearch"
  }

  snapshot_options {
    automated_snapshot_start_hour = 23
  }

  tags = {
    Domain = "TestDomain"
  }
}

References

  • #0000
@alexisde alexisde added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 8, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 8, 2019
@ghost ghost added the service/elasticsearch Issues and PRs that pertain to the elasticsearch service. label Oct 8, 2019
@aeschright aeschright removed the needs-triage Waiting for first response or review from a maintainer. label Dec 12, 2019
@bflad bflad added this to the v2.47.0 milestone Jan 29, 2020
@bflad
Copy link
Contributor

bflad commented Jan 29, 2020

Support for this functionality in the aws_elasticsearch_domain resource has been added via a new domain_endpoint_options configuration block:

resource "aws_elasticsearch_domain" "example" {
  # ... other configuration ...

  domain_endpoint_options {
    enforce_https = true
  }
}

And will release with version 2.47.0 of the Terraform AWS Provider, tomorrow. Thanks to @barrytam20 for the implementation. 👍

@ghost
Copy link

ghost commented Jan 30, 2020

This has been released in version 2.47.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants