Missing public for aws_ami and aws_ami_from_instance

[cadavre]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently there's no way to mark created AMI image as available public. Proposal is to add public parameter that defaults to false. Setting to true would mark AMI public and accessible for all.

New or Affected Resource(s)

• aws_ami
• aws_ami_from_instance
• aws_ami_copy (nice-to-have)

Potential Terraform Configuration

resource "aws_ami_from_instance" "my_ami" {
  name               = "my-ami"
  source_instance_id = aws_instance.ami_source.id
  public             = true
}

[atz]

I think this implies reworking aws_ami_launch_permission to accept more than just an account_id (specifically public). Or is it the (undocumented) case that aws_ami_launch_permission already accepts public as an account_id?

If I try to construct a launch permission with account_id="public" (or "all"), I get:

Error: error creating ami launch permission: InvalidAMIAttributeItemValue: Invalid attribute item value "public " for userId item type.
... or ...
Error: error creating ami launch permission: InvalidAMIAttributeItemValue: Invalid attribute item value "all " for userId item type.

So I think the launch permission has to change to unblock this. (Not sure why the extra space in the error messages' quote marks.)

[grahamc]

I've implemented this in #20677, and you can use it pretty easily if you're using Nix to manage your Terraform environment. See: #20677 (comment)

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.