r/gamelift_script - add new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Depends on #22966

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGameliftScript_'
--- PASS: TestAccAWSGameliftScript_basic (120.55s)
--- PASS: TestAccAWSGameliftScript_tags (158.11s)
--- PASS: TestAccAWSGameliftScript_disappears (47.80s)

--- PASS: TestAccGameLiftFleet_script (1713.23s)

[DrFaust92]

Add some missing stuff, retry and simplify tests.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGameLiftFleet_\|TestAccGameLiftScript_' PKG=gamelift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/gamelift/... -v -count 1 -parallel 20  -run=TestAccGameLiftFleet_\|TestAccGameLiftScript_ -timeout 180m
=== RUN   TestAccGameLiftFleet_basic
=== PAUSE TestAccGameLiftFleet_basic
=== RUN   TestAccGameLiftFleet_tags
=== PAUSE TestAccGameLiftFleet_tags
=== RUN   TestAccGameLiftFleet_allFields
=== PAUSE TestAccGameLiftFleet_allFields
=== RUN   TestAccGameLiftFleet_cert
=== PAUSE TestAccGameLiftFleet_cert
=== RUN   TestAccGameLiftFleet_script
=== PAUSE TestAccGameLiftFleet_script
=== RUN   TestAccGameLiftFleet_disappears
=== PAUSE TestAccGameLiftFleet_disappears
=== RUN   TestAccGameLiftScript_basic
=== PAUSE TestAccGameLiftScript_basic
=== RUN   TestAccGameLiftScript_tags
=== PAUSE TestAccGameLiftScript_tags
=== RUN   TestAccGameLiftScript_disappears
=== PAUSE TestAccGameLiftScript_disappears
=== CONT  TestAccGameLiftFleet_basic
=== CONT  TestAccGameLiftFleet_disappears
=== CONT  TestAccGameLiftScript_tags
=== CONT  TestAccGameLiftScript_disappears
=== CONT  TestAccGameLiftFleet_cert
=== CONT  TestAccGameLiftFleet_script
=== CONT  TestAccGameLiftScript_basic
=== CONT  TestAccGameLiftFleet_allFields
=== CONT  TestAccGameLiftFleet_tags
--- PASS: TestAccGameLiftScript_disappears (20.02s)
--- PASS: TestAccGameLiftScript_basic (43.10s)
--- PASS: TestAccGameLiftScript_tags (58.82s)
--- PASS: TestAccGameLiftFleet_script (1415.58s)
--- PASS: TestAccGameLiftFleet_disappears (1938.34s)
--- PASS: TestAccGameLiftFleet_cert (2015.93s)
--- PASS: TestAccGameLiftFleet_basic (2135.81s)
--- PASS: TestAccGameLiftFleet_tags (2271.84s)
--- PASS: TestAccGameLiftFleet_allFields (4132.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	4136.094s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.