resource/aws_sns_topic_subscription: Add redrive_policy argument fixes #10931

[Ricool06]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10931

Release note for CHANGELOG:

resource_aws_sns_topic_subscription: add `redrive_policy` argument.

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopicSubscription_redrivePolicy'

==> Checking that code complies with gofmt requirements...

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicSubscription_redrivePolicy -timeout 120m

=== RUN   TestAccAWSSNSTopicSubscription_redrivePolicy

=== PAUSE TestAccAWSSNSTopicSubscription_redrivePolicy

=== CONT  TestAccAWSSNSTopicSubscription_redrivePolicy

--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (182.14s)

PASS

ok      github.com/terraform-providers/terraform-provider-aws/aws       185.013s

[Ricool06]

Sorry, I've opened the PR from my phone, I will fill out the rest of the description when I have access to a better text editor. I need help writing the tests for this as I have never written Go before. 😊

[Ricool06]

Tests are complete now.

[jamesanto]

Hi, is there anything I can do to speed it up?

[Ricool06]

Hi, is there anything I can do to speed it up?

If you are part of the terraform team, please review the changes. If not, they recommend 👍 ing the PR and referenced issue. I'm sure the notification for my PR or the issue has bugged out for some reason.

[kabo]

ping @bflad maybe ?

[kabo]

ping @maryelizbeth maybe?

[Ricool06]

I don't know who the active reviewers are, or how to ping them directly. It's also probably a bit of an overreach to go DMing them all over Twitter. I posted on the terraform gitter, but nobody has responded to me.

[kabo]

Yeah, to be clear I'm not asking you to ping them, I'm pinging them to hopefully get them to have a look.

[Ricool06]

Ah okay, thank you.

[anGie44]

Hi @Ricool06 -- thanks again for your contributions to this resource enhancement. Overall looks great 👍 I've rebased and will be making the folllowing updates to get this merged and added into our next release:

• add .changelog file
• pass redrive_policy argument on Create
• update test check to generalize the queue ARN so we don't have hardcoded regions

[anGie44]

Thanks again @Ricool06 🚀 !

Output of acceptance tests:

--- PASS: TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy (0.00s)
--- PASS: TestObfuscateEndpointPassword (0.00s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (23.05s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (45.12s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (45.63s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (45.71s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (46.63s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (47.62s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (76.27s)

[Ricool06]

Thanks again @Ricool06 🚀 !

Output of acceptance tests:

--- PASS: TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy (0.00s)
--- PASS: TestObfuscateEndpointPassword (0.00s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (23.05s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (45.12s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (45.63s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (45.71s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (46.63s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (47.62s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (76.27s)

Thanks for getting to this! Feeling lots of relief knowing this issue is coming close to resolution 😊

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!