Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing aws_mq_broker engine_version should not force resource replacement #11827

Closed
WillSewell opened this issue Jan 31, 2020 · 4 comments · Fixed by #12758
Closed

Changing aws_mq_broker engine_version should not force resource replacement #11827

WillSewell opened this issue Jan 31, 2020 · 4 comments · Fixed by #12758
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mq Issues and PRs that pertain to the mq service.
Milestone
v3.32.0

Comments

@WillSewell
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon MQ allows you to upgrade the engine version in place, however the AWS provider forces a replacement of the resource if the engine_version is updated.

New or Affected Resource(s)

  • aws_mq_broker
@WillSewell WillSewell added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 31, 2020
@ghost ghost added the service/mq Issues and PRs that pertain to the mq service. label Jan 31, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 31, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 31, 2020
@tomelliff
Copy link
Contributor

This support was added in v1.15.44 of the Go SDK but was previously not possible to change as there wasn't an EngineVersion field on the UpdateBrokerRequest struct.

@DrFaust92 DrFaust92 mentioned this issue Apr 10, 2020
Merged
@DrFaust92
Copy link
Collaborator

addressed in #12758

@YakDriver YakDriver added this to the v3.32.0 milestone Mar 10, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mq Issues and PRs that pertain to the mq service.
Projects
None yet
Milestone
v3.32.0
Development

Successfully merging a pull request may close this issue.

r/mq_broker - allow updating engine version DrFaust92/terraform-provider-aws
5 participants
@bflad @WillSewell @tomelliff @YakDriver @DrFaust92