-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_iot_provisioning_template resource #12108
Add aws_iot_provisioning_template resource #12108
Conversation
Fleet provisioning is in GA now and available in most (all?) regions: https://aws.amazon.com/about-aws/whats-new/2020/04/announcing-general-availability-of-aws-iot-core-fleet-provisioning/ |
Notification of Recent and Upcoming Changes to ContributionsThank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization. If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items. For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported. Terraform 0.12 SyntaxReference: #8950 Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations ( Action Required: Terraform Plugin SDK Version 2Reference: #14551 The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information. Action Required: Removal of website/aws.erb FileReference: #14712 Any changes to the Upcoming Change of Git Branch NamingReference: #14292 Development environments will need their upstream Git branch updated from Upcoming Change of GitHub OrganizationReference: #14715 This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including |
Hello! Is there any update for the PR? This resource would be highly appreciated. I'm happy to help with the leftovers if needed. 👍 |
It's been ready for a while, but the Terraform team is overwhelmed with issues and PRs unfortunately. I'm going to take care of the above needed changes in the next week or so. |
Yay, thanks a lot! 👍 |
This should be good for review again.
|
Hi :) When do you plan to release this feature? |
Agreed, this is a major limitation to using AWS IoT. What's an ETA for review? |
I'm very impatient to see this new feature. Thanks in advance. |
Sorry for bothering. This feature being missing is currently a show-stopper for me, any news? 🙂 |
Hi, would someone from the Terraform dev community be able to give any indication as to when this PR for IoT fleet provisioning will be merged? Thanks. |
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
This reverts commit ae2f056.
This reverts commit e1737d7.
This reverts commit ffc3e58.
This reverts commit 7071637.
This reverts commit 1bbf5aa.
This reverts commit 299451b.
This reverts commit 2e0a1df.
Acceptance test output: % make testacc TESTS=TestAccIoTProvisioningTemplate_ PKG=iot ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTProvisioningTemplate_' -timeout 180m === RUN TestAccIoTProvisioningTemplate_basic --- PASS: TestAccIoTProvisioningTemplate_basic (36.10s) === RUN TestAccIoTProvisioningTemplate_disappears --- PASS: TestAccIoTProvisioningTemplate_disappears (22.58s) === RUN TestAccIoTProvisioningTemplate_tags --- PASS: TestAccIoTProvisioningTemplate_tags (59.08s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 121.496s
Acceptance test output: % make testacc TESTS=TestAccIoTProvisioningTemplate_ PKG=iot ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTProvisioningTemplate_' -timeout 180m === RUN TestAccIoTProvisioningTemplate_basic === PAUSE TestAccIoTProvisioningTemplate_basic === RUN TestAccIoTProvisioningTemplate_disappears === PAUSE TestAccIoTProvisioningTemplate_disappears === RUN TestAccIoTProvisioningTemplate_tags === PAUSE TestAccIoTProvisioningTemplate_tags === RUN TestAccIoTProvisioningTemplate_update === PAUSE TestAccIoTProvisioningTemplate_update === CONT TestAccIoTProvisioningTemplate_basic === CONT TestAccIoTProvisioningTemplate_tags --- PASS: TestAccIoTProvisioningTemplate_basic (34.32s) === CONT TestAccIoTProvisioningTemplate_update --- PASS: TestAccIoTProvisioningTemplate_tags (57.94s) === CONT TestAccIoTProvisioningTemplate_disappears --- PASS: TestAccIoTProvisioningTemplate_update (45.06s) --- PASS: TestAccIoTProvisioningTemplate_disappears (30.26s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 91.917s
97ecc27
to
63e9034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccIoTProvisioningTemplate_ PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTProvisioningTemplate_' -timeout 180m
=== RUN TestAccIoTProvisioningTemplate_basic
=== PAUSE TestAccIoTProvisioningTemplate_basic
=== RUN TestAccIoTProvisioningTemplate_disappears
=== PAUSE TestAccIoTProvisioningTemplate_disappears
=== RUN TestAccIoTProvisioningTemplate_tags
=== PAUSE TestAccIoTProvisioningTemplate_tags
=== RUN TestAccIoTProvisioningTemplate_update
=== PAUSE TestAccIoTProvisioningTemplate_update
=== CONT TestAccIoTProvisioningTemplate_basic
=== CONT TestAccIoTProvisioningTemplate_tags
--- PASS: TestAccIoTProvisioningTemplate_basic (34.32s)
=== CONT TestAccIoTProvisioningTemplate_update
--- PASS: TestAccIoTProvisioningTemplate_tags (57.94s)
=== CONT TestAccIoTProvisioningTemplate_disappears
--- PASS: TestAccIoTProvisioningTemplate_update (45.06s)
--- PASS: TestAccIoTProvisioningTemplate_disappears (30.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 91.917s
…, use aws_partition data source'.
@oleg-codaio Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds the resource
aws_iot_provisioning_template
to enable creating IoT Fleet Provisioning Templates. This is a new AWS IoT feature, still in beta, that allows IoT to automatically create and deliver device certificates and private keys to new devices as they connect to IoT.Community Note
Closes #12107
Release note for CHANGELOG:
Output from acceptance testing:
Notes
us-east-1
aws_iot_policy