Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_iot_provisioning_template resource #12108

Merged

Conversation

oleg-codaio
Copy link
Contributor

Adds the resource aws_iot_provisioning_template to enable creating IoT Fleet Provisioning Templates. This is a new AWS IoT feature, still in beta, that allows IoT to automatically create and deliver device certificates and private keys to new devices as they connect to IoT.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12107

Release note for CHANGELOG:

**New resource**: `aws_iot_provisioning_template`

Output from acceptance testing:

$ AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAWSIoTProvisioningTemplate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSIoTProvisioningTemplate -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSIoTProvisioningTemplate_basic
=== PAUSE TestAccAWSIoTProvisioningTemplate_basic
=== CONT  TestAccAWSIoTProvisioningTemplate_basic
--- PASS: TestAccAWSIoTProvisioningTemplate_basic (49.26s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.911s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.342s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.247s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency    0.247s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token    0.157s [no tests to run]
?       github.com/terraform-providers/terraform-provider-aws/awsproviderlint   [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes    0.631s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001   0.307s [no tests to run]

Notes

  • Fleet provisioning is currently only available in us-east-1
  • Changes to template bodies are made via new versions, exposed in the AWS API. To simplify usage, any changes to template bodies result in a new version being created and set as the default under the hood. This seems fine since Terraform is essentially the versioning provider, and is in line with the implementation of other resources like aws_iot_policy

@oleg-codaio oleg-codaio requested a review from a team February 20, 2020 20:32
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 20, 2020
@l85m
Copy link

l85m commented May 30, 2020

Fleet provisioning is currently only available in us-east-1

Fleet provisioning is in GA now and available in most (all?) regions: https://aws.amazon.com/about-aws/whats-new/2020/04/announcing-general-availability-of-aws-iot-core-fleet-provisioning/

@teamterraform
Copy link

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

@burningalchemist
Copy link

Hello! Is there any update for the PR? This resource would be highly appreciated. I'm happy to help with the leftovers if needed. 👍

@oleg-codaio
Copy link
Contributor Author

oleg-codaio commented Aug 25, 2020

It's been ready for a while, but the Terraform team is overwhelmed with issues and PRs unfortunately. I'm going to take care of the above needed changes in the next week or so.

@burningalchemist
Copy link

Yay, thanks a lot! 👍

@oleg-codaio
Copy link
Contributor Author

This should be good for review again.

$ AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAWSIoTProvisioningTemplate' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTProvisioningTemplate -timeout 120m
=== RUN   TestAccAWSIoTProvisioningTemplate_basic
=== PAUSE TestAccAWSIoTProvisioningTemplate_basic
=== CONT  TestAccAWSIoTProvisioningTemplate_basic
--- PASS: TestAccAWSIoTProvisioningTemplate_basic (47.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       49.231s

@agacel1
Copy link

agacel1 commented Oct 20, 2020

Hi :) When do you plan to release this feature?

@KyleKotowick
Copy link
Contributor

Agreed, this is a major limitation to using AWS IoT. What's an ETA for review?

@Fran-E
Copy link

Fran-E commented Dec 16, 2020

I'm very impatient to see this new feature. Thanks in advance.

Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@emazzotta
Copy link

Sorry for bothering. This feature being missing is currently a show-stopper for me, any news? 🙂

@cgddrd-gardin
Copy link
Contributor

Hi, would someone from the Terraform dev community be able to give any indication as to when this PR for IoT fleet provisioning will be merged? Thanks.

@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

This reverts commit ffc3e58.
This reverts commit 7071637.
This reverts commit 299451b.
Acceptance test output:

% make testacc TESTS=TestAccIoTProvisioningTemplate_ PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTProvisioningTemplate_'  -timeout 180m
=== RUN   TestAccIoTProvisioningTemplate_basic
--- PASS: TestAccIoTProvisioningTemplate_basic (36.10s)
=== RUN   TestAccIoTProvisioningTemplate_disappears
--- PASS: TestAccIoTProvisioningTemplate_disappears (22.58s)
=== RUN   TestAccIoTProvisioningTemplate_tags
--- PASS: TestAccIoTProvisioningTemplate_tags (59.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	121.496s
Acceptance test output:

% make testacc TESTS=TestAccIoTProvisioningTemplate_ PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTProvisioningTemplate_'  -timeout 180m
=== RUN   TestAccIoTProvisioningTemplate_basic
=== PAUSE TestAccIoTProvisioningTemplate_basic
=== RUN   TestAccIoTProvisioningTemplate_disappears
=== PAUSE TestAccIoTProvisioningTemplate_disappears
=== RUN   TestAccIoTProvisioningTemplate_tags
=== PAUSE TestAccIoTProvisioningTemplate_tags
=== RUN   TestAccIoTProvisioningTemplate_update
=== PAUSE TestAccIoTProvisioningTemplate_update
=== CONT  TestAccIoTProvisioningTemplate_basic
=== CONT  TestAccIoTProvisioningTemplate_tags
--- PASS: TestAccIoTProvisioningTemplate_basic (34.32s)
=== CONT  TestAccIoTProvisioningTemplate_update
--- PASS: TestAccIoTProvisioningTemplate_tags (57.94s)
=== CONT  TestAccIoTProvisioningTemplate_disappears
--- PASS: TestAccIoTProvisioningTemplate_update (45.06s)
--- PASS: TestAccIoTProvisioningTemplate_disappears (30.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	91.917s
@ewbankkit ewbankkit force-pushed the osv-add-aws_iot_provisioning_template branch from 97ecc27 to 63e9034 Compare April 1, 2022 21:05
@github-actions github-actions bot added the service/backup Issues and PRs that pertain to the backup service. label Apr 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccIoTProvisioningTemplate_ PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run='TestAccIoTProvisioningTemplate_'  -timeout 180m
=== RUN   TestAccIoTProvisioningTemplate_basic
=== PAUSE TestAccIoTProvisioningTemplate_basic
=== RUN   TestAccIoTProvisioningTemplate_disappears
=== PAUSE TestAccIoTProvisioningTemplate_disappears
=== RUN   TestAccIoTProvisioningTemplate_tags
=== PAUSE TestAccIoTProvisioningTemplate_tags
=== RUN   TestAccIoTProvisioningTemplate_update
=== PAUSE TestAccIoTProvisioningTemplate_update
=== CONT  TestAccIoTProvisioningTemplate_basic
=== CONT  TestAccIoTProvisioningTemplate_tags
--- PASS: TestAccIoTProvisioningTemplate_basic (34.32s)
=== CONT  TestAccIoTProvisioningTemplate_update
--- PASS: TestAccIoTProvisioningTemplate_tags (57.94s)
=== CONT  TestAccIoTProvisioningTemplate_disappears
--- PASS: TestAccIoTProvisioningTemplate_update (45.06s)
--- PASS: TestAccIoTProvisioningTemplate_disappears (30.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	91.917s

@ewbankkit ewbankkit removed the service/backup Issues and PRs that pertain to the backup service. label Apr 1, 2022
@github-actions github-actions bot added the service/backup Issues and PRs that pertain to the backup service. label Apr 1, 2022
@ewbankkit ewbankkit merged commit 713ff0a into hashicorp:main Apr 2, 2022
@ewbankkit ewbankkit removed the service/backup Issues and PRs that pertain to the backup service. label Apr 2, 2022
@github-actions github-actions bot added this to the v4.9.0 milestone Apr 2, 2022
@ewbankkit
Copy link
Contributor

@oleg-codaio Thanks for the contribution 🎉 👏.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
@oleg-codaio oleg-codaio deleted the osv-add-aws_iot_provisioning_template branch May 8, 2022 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/iot Issues and PRs that pertain to the iot service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Resource: AWS IoT Fleet Provisioning Template