-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_s3_bucket_cors_configuration resource #12141
Conversation
The failed check is due to a code lint problem from the most recent merge into master. I will rebase this PR once that's been resolved. @bflad let me know if you want me to fold a fix to that here. |
@drexler thanks for the heads up -- fixed on master and will re-run CI for this pull request. |
@bflad mind reviewing this? |
Since there's no changes on the aws_s3_bucket resource, wouldn't there be a lifecycle conflict between aws_s3_bucket that deletes any existing CORS rules (since cors_rules isn't set) and aws_s3_bucket_cors_configuration that expects CORS rule to be present ? |
Notification of Recent and Upcoming Changes to ContributionsThank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization. If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items. For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported. Action Required: Terraform 0.12 SyntaxReference: #8950 Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations ( Action Required: Terraform Plugin SDK Version 2Reference: #14551 The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information. Action Required: Removal of website/aws.erb FileReference: #14712 Any changes to the Upcoming Change of Git Branch NamingReference: #14292 Development environments will need their upstream Git branch updated from Upcoming Change of GitHub OrganizationReference: #14715 This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including |
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
Hi @drexler , thanks so much for this PR! we're finally getting around to the major release work that aims to support more independent S3 bucket resources so I'll be actively reviewing this PR and get it ready for merging. I went about creating #22619 without seeing this PR first, so I may port some tests over from there but will use your contributions here as the base. I'll make an attempt to rebase if I have permissions to edit this PR, otherwise I'll need to cherry pick the commits in a new PR and go from there. |
828e6ca
to
05f81ed
Compare
Output of acceptance tests (commercial):
Output of acceptance tests (gov cloud):
|
6fce80f
to
8ead9cb
Compare
8ead9cb
to
90e21f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @drexler , LGTM 🎸
* docs: document S3 CORS configuration resource * r/s3_bucket_cors_configuration: CR updates * r/s3_bucket_cors_configuration: update ID methods to generic ones; docs formatting * correct error message Co-authored-by: Angie Pinilla <angie@hashicorp.com>
* docs: document S3 CORS configuration resource * r/s3_bucket_cors_configuration: CR updates * r/s3_bucket_cors_configuration: update ID methods to generic ones; docs formatting * correct error message Co-authored-by: Angie Pinilla <angie@hashicorp.com>
* docs: document S3 CORS configuration resource * r/s3_bucket_cors_configuration: CR updates * r/s3_bucket_cors_configuration: update ID methods to generic ones; docs formatting * correct error message Co-authored-by: Angie Pinilla <angie@hashicorp.com>
* docs: document S3 CORS configuration resource * r/s3_bucket_cors_configuration: CR updates * r/s3_bucket_cors_configuration: update ID methods to generic ones; docs formatting * correct error message Co-authored-by: Angie Pinilla <angie@hashicorp.com>
* docs: document S3 CORS configuration resource * r/s3_bucket_cors_configuration: CR updates * r/s3_bucket_cors_configuration: update ID methods to generic ones; docs formatting * correct error message Co-authored-by: Angie Pinilla <angie@hashicorp.com>
* docs: document S3 CORS configuration resource * r/s3_bucket_cors_configuration: CR updates * r/s3_bucket_cors_configuration: update ID methods to generic ones; docs formatting * correct error message Co-authored-by: Angie Pinilla <angie@hashicorp.com>
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #4418
Relates #22776
Release note for CHANGELOG:
Output from acceptance testing: