Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Storage GW SMB File Share Admin User List #12255

Closed
Andrew-Kulpa opened this issue Mar 4, 2020 · 3 comments · Fixed by #12196
Closed

Support AWS Storage GW SMB File Share Admin User List #12255

Andrew-Kulpa opened this issue Mar 4, 2020 · 3 comments · Fixed by #12196
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service.
Milestone

Comments

@Andrew-Kulpa
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Storage Gateway SMB File Share adds support for specifying admin user list.

New or Affected Resource(s)

  • aws_storagegateway_smb_file_share

Potential Terraform Configuration

resource "aws_storagegateway_smb_file_share" "example" {
  #...
  admin_user_list = ["@smb_admins"]
}

Attempted Solutions

References

@Andrew-Kulpa Andrew-Kulpa added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 4, 2020
@ghost ghost added the service/storagegateway Issues and PRs that pertain to the storagegateway service. label Mar 4, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 4, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Aug 20, 2020
@bflad bflad self-assigned this Sep 18, 2020
@bflad bflad added this to the v3.8.0 milestone Sep 18, 2020
@bflad
Copy link
Contributor

bflad commented Sep 21, 2020

Support for this functionality has been merged and will release with version 3.8.0 of the Terraform AWS Provider, later this week. Thanks to @Andrew-Kulpa for the implementation. 👍

@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service.
Projects
None yet
2 participants