Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/budgets_budget - add arn attribute + plan time validations #13139

Merged
merged 7 commits into from
Feb 11, 2021
Merged

r/budgets_budget - add arn attribute + plan time validations #13139

merged 7 commits into from
Feb 11, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 3, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624
Relates #13826

Release note for CHANGELOG:

resource_aws_budgets_budget: add `arn` attribute
resource_aws_budgets_budget: add plan time validations `budget_type`, `time_unit` and `subscriber_sns_topic_arns`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSBudgetsBudget_'
--- PASS: TestAccAWSBudgetsBudget_basic (81.82s)
--- PASS: TestAccAWSBudgetsBudget_prefix (73.28s)
--- PASS: TestAccAWSBudgetsBudget_notification (243.72s)
--- PASS: TestAccAWSBudgetsBudget_disappears (49.66s)

@DrFaust92 DrFaust92 requested a review from a team May 3, 2020 18:14
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/budgets Issues and PRs that pertain to the budgets service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 3, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSBudgetsBudget_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudget_ -timeout 120m
=== RUN   TestAccAWSBudgetsBudget_basic
=== PAUSE TestAccAWSBudgetsBudget_basic
=== RUN   TestAccAWSBudgetsBudget_prefix
=== PAUSE TestAccAWSBudgetsBudget_prefix
=== RUN   TestAccAWSBudgetsBudget_notification
=== PAUSE TestAccAWSBudgetsBudget_notification
=== CONT  TestAccAWSBudgetsBudget_basic
=== CONT  TestAccAWSBudgetsBudget_notification
=== CONT  TestAccAWSBudgetsBudget_prefix
--- PASS: TestAccAWSBudgetsBudget_prefix (35.78s)
--- PASS: TestAccAWSBudgetsBudget_basic (40.09s)
--- PASS: TestAccAWSBudgetsBudget_notification (117.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	117.278s

@DrFaust92
Copy link
Collaborator Author

added disappears test case

@DrFaust92 DrFaust92 force-pushed the r/budgets_budget_validations branch from a32ad75 to f0d7b2a Compare June 18, 2020 09:49
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 18, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/L Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. labels Sep 4, 2020
@DrFaust92 DrFaust92 removed the service/storagegateway Issues and PRs that pertain to the storagegateway service. label Sep 24, 2020
Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
bflad
bflad approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSBudgetsBudget_disappears (8.81s)
--- PASS: TestAccAWSBudgetsBudget_prefix (18.83s)
--- PASS: TestAccAWSBudgetsBudget_basic (22.27s)
--- PASS: TestAccAWSBudgetsBudget_notification (64.76s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSBudgetsBudget_basic (1.38s)
--- SKIP: TestAccAWSBudgetsBudget_prefix (1.38s)
--- SKIP: TestAccAWSBudgetsBudget_disappears (1.38s)
--- SKIP: TestAccAWSBudgetsBudget_notification (1.38s)

bflad added a commit that referenced this pull request Feb 11, 2021
@bflad
resource/aws_budgets_budget: Fix disappears test and add CHANGELOG for …
3ce9225 
…#13139

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSBudgetsBudget_disappears (8.81s)
--- PASS: TestAccAWSBudgetsBudget_prefix (18.83s)
--- PASS: TestAccAWSBudgetsBudget_basic (22.27s)
--- PASS: TestAccAWSBudgetsBudget_notification (64.76s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccAWSBudgetsBudget_basic (1.38s)
--- SKIP: TestAccAWSBudgetsBudget_prefix (1.38s)
--- SKIP: TestAccAWSBudgetsBudget_disappears (1.38s)
--- SKIP: TestAccAWSBudgetsBudget_notification (1.38s)
```
@bflad bflad merged commit fe44198 into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/budgets_budget_validations branch April 15, 2021 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/budgets Issues and PRs that pertain to the budgets service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @ewbankkit @bflad