Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Network Manager for Transit Gateways #13251

Merged
merged 120 commits into from
Mar 14, 2022

Conversation

Omarimcblack
Copy link
Contributor

@Omarimcblack Omarimcblack commented May 10, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11132

Release note for CHANGELOG:

New Resource: aws_networkmanager_global_network (#13251)
New Resource: aws_networkmanager_site (#13251)
New Resource: aws_networkmanager_device (#13251)
New Resource: aws_networkmanager_transit_gateway_registration (#13251)
New Datasource: aws_networkmanager_global_network (#13251)
New Datasource: aws_networkmanager_site (#13251)
New Datasource: aws_networkmanager_device (#13251)

Pending releases

New Resource: aws_networkmanager_link ()
New Resource: aws_networkmanager_customer_gateway_association ()
New Resource: aws_networkmanager_link_association ()

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerGlobalNetwork'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerGlobalNetwork -timeout 120m
=== RUN   TestAccAWSNetworkManagerGlobalNetwork_basic
=== PAUSE TestAccAWSNetworkManagerGlobalNetwork_basic
=== RUN   TestAccAWSNetworkManagerGlobalNetwork_tags
=== PAUSE TestAccAWSNetworkManagerGlobalNetwork_tags
=== CONT  TestAccAWSNetworkManagerGlobalNetwork_basic
=== CONT  TestAccAWSNetworkManagerGlobalNetwork_tags
--- PASS: TestAccAWSNetworkManagerGlobalNetwork_basic (68.59s)
--- PASS: TestAccAWSNetworkManagerGlobalNetwork_tags (90.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       91.320s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerSite'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerSite -timeout 120m
=== RUN   TestAccAWSNetworkManagerSite_basic
=== PAUSE TestAccAWSNetworkManagerSite_basic
=== RUN   TestAccAWSNetworkManagerSite_tags
=== PAUSE TestAccAWSNetworkManagerSite_tags
=== CONT  TestAccAWSNetworkManagerSite_basic
=== CONT  TestAccAWSNetworkManagerSite_tags
--- PASS: TestAccAWSNetworkManagerSite_basic (77.56s)
--- PASS: TestAccAWSNetworkManagerSite_tags (95.33s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       96.521s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerDevice'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerDevice -timeout 120m
MYDEBUG:        resourceAwsNetworkManagerLink()
=== RUN   TestAccAWSNetworkManagerDevice_basic
=== PAUSE TestAccAWSNetworkManagerDevice_basic
=== RUN   TestAccAWSNetworkManagerDevice_tags
=== PAUSE TestAccAWSNetworkManagerDevice_tags
=== CONT  TestAccAWSNetworkManagerDevice_basic
=== CONT  TestAccAWSNetworkManagerDevice_tags
--- PASS: TestAccAWSNetworkManagerDevice_basic (79.77s)
--- PASS: TestAccAWSNetworkManagerDevice_tags (127.77s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       128.780s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerTransitGatewayRegistration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerTransitGatewayRegistration -timeout 120m
=== RUN   TestAccAWSNetworkManagerTransitGatewayRegistration_basic
=== PAUSE TestAccAWSNetworkManagerTransitGatewayRegistration_basic
=== CONT  TestAccAWSNetworkManagerTransitGatewayRegistration_basic
--- PASS: TestAccAWSNetworkManagerTransitGatewayRegistration_basic (237.71s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       238.925s

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSNetworkManager'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSNetworkManager -timeout 120m
=== RUN   TestAccDataSourceAWSNetworkManagerGlobalNetwork
=== PAUSE TestAccDataSourceAWSNetworkManagerGlobalNetwork
=== CONT  TestAccDataSourceAWSNetworkManagerGlobalNetwork
--- PASS: TestAccDataSourceAWSNetworkManagerGlobalNetwork (45.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       46.280s

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSNetworkManagerSite'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSNetworkManagerSite -timeout 120m
=== RUN   TestAccDataSourceAWSNetworkManagerSite
=== PAUSE TestAccDataSourceAWSNetworkManagerSite
=== CONT  TestAccDataSourceAWSNetworkManagerSite
--- PASS: TestAccDataSourceAWSNetworkManagerSite (44.82s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       45.806s

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSNetworkManagerDevice'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSNetworkManagerDevice -timeout 120m
=== RUN   TestAccDataSourceAWSNetworkManagerDevice
=== PAUSE TestAccDataSourceAWSNetworkManagerDevice
=== CONT  TestAccDataSourceAWSNetworkManagerDevice
--- PASS: TestAccDataSourceAWSNetworkManagerDevice (62.20s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       63.223s
...

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 10, 2020
@ewbankkit
Copy link
Contributor

@Omarimcblack Thanks for starting on this.
In order to speed things up a bit I would suggest splitting the new networkmanager service additions and keyvaluetags tagging code into their own PR with help from the Contributing Guide.
That PR can then be merged relatively quickly.

@Omarimcblack
Copy link
Contributor Author

@Omarimcblack Thanks for starting on this.
In order to speed things up a bit I would suggest splitting the new networkmanager service additions and keyvaluetags tagging code into their own PR with help from the Contributing Guide.
That PR can then be merged relatively quickly.

Thanks @ewbankkit I have opened a new PR to hopefully capture your request, test are still outstanding.

The identifier for calls to keyvaluetags.NetworkmanagerUpdateTags is the
resource arn not the resource id

output from acceptance tests:
make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerGlobalNetwork'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerGlobalNetwork -timeout 120m
=== RUN   TestAccAWSNetworkManagerGlobalNetwork_basic
=== PAUSE TestAccAWSNetworkManagerGlobalNetwork_basic
=== RUN   TestAccAWSNetworkManagerGlobalNetwork_tags
=== PAUSE TestAccAWSNetworkManagerGlobalNetwork_tags
=== CONT  TestAccAWSNetworkManagerGlobalNetwork_basic
=== CONT  TestAccAWSNetworkManagerGlobalNetwork_tags
--- PASS: TestAccAWSNetworkManagerGlobalNetwork_basic (68.59s)
--- PASS: TestAccAWSNetworkManagerGlobalNetwork_tags (90.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       91.320s

also correct debug message
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels May 12, 2020
output from acceptance tests:
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerDevice'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerDevice -timeout 120m
MYDEBUG:        resourceAwsNetworkManagerLink()
=== RUN   TestAccAWSNetworkManagerDevice_basic
=== PAUSE TestAccAWSNetworkManagerDevice_basic
=== RUN   TestAccAWSNetworkManagerDevice_tags
=== PAUSE TestAccAWSNetworkManagerDevice_tags
=== CONT  TestAccAWSNetworkManagerDevice_basic
=== CONT  TestAccAWSNetworkManagerDevice_tags
--- PASS: TestAccAWSNetworkManagerDevice_basic (79.77s)
--- PASS: TestAccAWSNetworkManagerDevice_tags (127.77s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       128.780s
Output from acceptance test:
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerTransitGatewayRegistration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerTransitGatewayRegistration -timeout 120m
=== RUN   TestAccAWSNetworkManagerTransitGatewayRegistration_basic
=== PAUSE TestAccAWSNetworkManagerTransitGatewayRegistration_basic
=== CONT  TestAccAWSNetworkManagerTransitGatewayRegistration_basic
--- PASS: TestAccAWSNetworkManagerTransitGatewayRegistration_basic (237.71s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       238.925s
@ghost ghost added service/networkmanager Issues and PRs that pertain to the networkmanager service. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. labels May 14, 2020
R004: ResourceData.Set() incompatible value type: *github.com/aws/aws-sdk-go/service/networkmanager.Location
resource_aws_networkmanager_device.go
resource_aws_networkmanager_site.go

R006: RetryFunc should include RetryableError() handling or be removed
resource_aws_networkmanager_transit_gateway_registration
Output from acceptance test:
$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSNetworkManager'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSNetworkManager -timeout 120m
=== RUN   TestAccDataSourceAWSNetworkManagerGlobalNetwork
=== PAUSE TestAccDataSourceAWSNetworkManagerGlobalNetwork
=== CONT  TestAccDataSourceAWSNetworkManagerGlobalNetwork
--- PASS: TestAccDataSourceAWSNetworkManagerGlobalNetwork (45.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       46.280s
Acceptance test output:

% make testacc TESTS=TestAccNetworkManagerLinkAssociation_ PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerLinkAssociation_'  -timeout 180m
=== RUN   TestAccNetworkManagerLinkAssociation_basic
=== PAUSE TestAccNetworkManagerLinkAssociation_basic
=== RUN   TestAccNetworkManagerLinkAssociation_disappears
=== PAUSE TestAccNetworkManagerLinkAssociation_disappears
=== CONT  TestAccNetworkManagerLinkAssociation_basic
=== CONT  TestAccNetworkManagerLinkAssociation_disappears
--- PASS: TestAccNetworkManagerLinkAssociation_disappears (24.07s)
--- PASS: TestAccNetworkManagerLinkAssociation_basic (28.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	32.548s
Acceptance test output:

% make testacc TESTARGS='-run=TestAccNetworkManageCustomerGatewayAssociation_serial' PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20  -run=TestAccNetworkManageCustomerGatewayAssociation_serial -timeout 180m
=== RUN   TestAccNetworkManageCustomerGatewayAssociation_serial
=== RUN   TestAccNetworkManageCustomerGatewayAssociation_serial/basic
=== RUN   TestAccNetworkManageCustomerGatewayAssociation_serial/disappears
=== RUN   TestAccNetworkManageCustomerGatewayAssociation_serial/disappears_CustomerGateway
--- PASS: TestAccNetworkManageCustomerGatewayAssociation_serial (2310.51s)
    --- PASS: TestAccNetworkManageCustomerGatewayAssociation_serial/basic (857.13s)
    --- PASS: TestAccNetworkManageCustomerGatewayAssociation_serial/disappears (738.83s)
    --- PASS: TestAccNetworkManageCustomerGatewayAssociation_serial/disappears_CustomerGateway (714.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	2314.041s
…in resource name: aws_networkmanager_customer_gateway_association'.
…source.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial' PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20  -run=TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial -timeout 180m
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer
--- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial (2520.30s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic (850.86s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears (837.86s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer (831.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	2523.822s
Acceptance test output:

% make testacc TESTS=TestAccNetworkManagerConnection_serial PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerConnection_serial'  -timeout 180m
=== RUN   TestAccNetworkManagerConnection_serial
=== RUN   TestAccNetworkManagerConnection_serial/descriptionAndLinks
=== RUN   TestAccNetworkManagerConnection_serial/basic
=== RUN   TestAccNetworkManagerConnection_serial/disappears
=== RUN   TestAccNetworkManagerConnection_serial/tags
--- PASS: TestAccNetworkManagerConnection_serial (158.75s)
    --- PASS: TestAccNetworkManagerConnection_serial/descriptionAndLinks (48.48s)
    --- PASS: TestAccNetworkManagerConnection_serial/basic (28.73s)
    --- PASS: TestAccNetworkManagerConnection_serial/disappears (26.78s)
    --- PASS: TestAccNetworkManagerConnection_serial/tags (54.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	162.480s
Acceptance test output:

% make testacc TESTS=TestAccNetworkManagerConnectionDataSource_ PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerConnectionDataSource_'  -timeout 180m
=== RUN   TestAccNetworkManagerConnectionDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionDataSource_basic
=== CONT  TestAccNetworkManagerConnectionDataSource_basic
--- PASS: TestAccNetworkManagerConnectionDataSource_basic (31.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	35.389s
Acceptance test output:

% make testacc TESTS=TestAccNetworkManagerLinkDataSource_ PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerLinkDataSource_'  -timeout 180m
=== RUN   TestAccNetworkManagerLinkDataSource_basic
=== PAUSE TestAccNetworkManagerLinkDataSource_basic
=== CONT  TestAccNetworkManagerLinkDataSource_basic
--- PASS: TestAccNetworkManagerLinkDataSource_basic (25.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	28.909s
Acceptance test output:

% make testacc TESTS=TestAccNetworkManagerConnectionsDataSource_ PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerConnectionsDataSource_'  -timeout 180m
=== RUN   TestAccNetworkManagerConnectionsDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionsDataSource_basic
=== CONT  TestAccNetworkManagerConnectionsDataSource_basic
--- PASS: TestAccNetworkManagerConnectionsDataSource_basic (32.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	35.619s
@github-actions github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Mar 12, 2022
@ewbankkit ewbankkit changed the title [WIP] Support for Global Network AWS Network Manager for Transit Gateways Mar 12, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccNetworkManager PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run='TestAccNetworkManager'  -timeout 180m
=== RUN   TestAccNetworkManagerConnectionDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionDataSource_basic
=== RUN   TestAccNetworkManagerConnection_serial
=== RUN   TestAccNetworkManagerConnection_serial/basic
=== RUN   TestAccNetworkManagerConnection_serial/disappears
=== RUN   TestAccNetworkManagerConnection_serial/tags
=== RUN   TestAccNetworkManagerConnection_serial/descriptionAndLinks
--- PASS: TestAccNetworkManagerConnection_serial (158.68s)
    --- PASS: TestAccNetworkManagerConnection_serial/basic (30.50s)
    --- PASS: TestAccNetworkManagerConnection_serial/disappears (26.39s)
    --- PASS: TestAccNetworkManagerConnection_serial/tags (57.37s)
    --- PASS: TestAccNetworkManagerConnection_serial/descriptionAndLinks (44.43s)
=== RUN   TestAccNetworkManagerConnectionsDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionsDataSource_basic
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/basic
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears_CustomerGateway
--- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial (2295.90s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/basic (733.43s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears (858.33s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears_CustomerGateway (704.14s)
=== RUN   TestAccNetworkManagerDeviceDataSource_basic
=== PAUSE TestAccNetworkManagerDeviceDataSource_basic
=== RUN   TestAccNetworkManagerDevice_basic
=== PAUSE TestAccNetworkManagerDevice_basic
=== RUN   TestAccNetworkManagerDevice_disappears
=== PAUSE TestAccNetworkManagerDevice_disappears
=== RUN   TestAccNetworkManagerDevice_tags
=== PAUSE TestAccNetworkManagerDevice_tags
=== RUN   TestAccNetworkManagerDevice_allAttributes
=== PAUSE TestAccNetworkManagerDevice_allAttributes
=== RUN   TestAccNetworkManagerDevice_awsLocation
=== PAUSE TestAccNetworkManagerDevice_awsLocation
=== RUN   TestAccNetworkManagerDevicesDataSource_basic
=== PAUSE TestAccNetworkManagerDevicesDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetworkDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworkDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_basic
=== PAUSE TestAccNetworkManagerGlobalNetwork_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_disappears
=== PAUSE TestAccNetworkManagerGlobalNetwork_disappears
=== RUN   TestAccNetworkManagerGlobalNetwork_tags
=== PAUSE TestAccNetworkManagerGlobalNetwork_tags
=== RUN   TestAccNetworkManagerGlobalNetwork_description
=== PAUSE TestAccNetworkManagerGlobalNetwork_description
=== RUN   TestAccNetworkManagerGlobalNetworksDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworksDataSource_basic
=== RUN   TestAccNetworkManagerLinkAssociation_basic
=== PAUSE TestAccNetworkManagerLinkAssociation_basic
=== RUN   TestAccNetworkManagerLinkAssociation_disappears
=== PAUSE TestAccNetworkManagerLinkAssociation_disappears
=== RUN   TestAccNetworkManagerLinkDataSource_basic
=== PAUSE TestAccNetworkManagerLinkDataSource_basic
=== RUN   TestAccNetworkManagerLink_basic
=== PAUSE TestAccNetworkManagerLink_basic
=== RUN   TestAccNetworkManagerLink_disappears
=== PAUSE TestAccNetworkManagerLink_disappears
=== RUN   TestAccNetworkManagerLink_tags
=== PAUSE TestAccNetworkManagerLink_tags
=== RUN   TestAccNetworkManagerLink_allAttributes
=== PAUSE TestAccNetworkManagerLink_allAttributes
=== RUN   TestAccNetworkManagerLinksDataSource_basic
=== PAUSE TestAccNetworkManagerLinksDataSource_basic
=== RUN   TestAccNetworkManagerSiteDataSource_basic
=== PAUSE TestAccNetworkManagerSiteDataSource_basic
=== RUN   TestAccNetworkManagerSite_basic
=== PAUSE TestAccNetworkManagerSite_basic
=== RUN   TestAccNetworkManagerSite_disappears
=== PAUSE TestAccNetworkManagerSite_disappears
=== RUN   TestAccNetworkManagerSite_tags
=== PAUSE TestAccNetworkManagerSite_tags
=== RUN   TestAccNetworkManagerSite_description
=== PAUSE TestAccNetworkManagerSite_description
=== RUN   TestAccNetworkManagerSite_location
=== PAUSE TestAccNetworkManagerSite_location
=== RUN   TestAccNetworkManagerSitesDataSource_basic
=== PAUSE TestAccNetworkManagerSitesDataSource_basic
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic
	=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer
--- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial (2475.97s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic (851.45s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears (825.89s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer (798.62s)
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/basic
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/disappears
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/disappears_TransitGateway
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/crossRegion
--- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial (1080.67s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/basic (277.70s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears (302.50s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears_TransitGateway (281.88s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/crossRegion (218.60s)
=== CONT  TestAccNetworkManagerConnectionDataSource_basic
=== CONT  TestAccNetworkManagerLinkAssociation_basic
--- PASS: TestAccNetworkManagerLinkAssociation_basic (30.82s)
=== CONT  TestAccNetworkManagerDevicesDataSource_basic
--- PASS: TestAccNetworkManagerConnectionDataSource_basic (31.60s)
=== CONT  TestAccNetworkManagerGlobalNetworksDataSource_basic
--- PASS: TestAccNetworkManagerDevicesDataSource_basic (19.08s)
=== CONT  TestAccNetworkManagerGlobalNetwork_description
--- PASS: TestAccNetworkManagerGlobalNetwork_description (31.19s)
=== CONT  TestAccNetworkManagerGlobalNetwork_tags
--- PASS: TestAccNetworkManagerGlobalNetwork_tags (46.52s)
=== CONT  TestAccNetworkManagerGlobalNetwork_disappears
--- PASS: TestAccNetworkManagerGlobalNetworksDataSource_basic (17.18s)
=== CONT  TestAccNetworkManagerGlobalNetwork_basic
--- PASS: TestAccNetworkManagerGlobalNetwork_disappears (15.12s)
=== CONT  TestAccNetworkManagerGlobalNetworkDataSource_basic
--- PASS: TestAccNetworkManagerGlobalNetwork_basic (18.43s)
=== CONT  TestAccNetworkManagerLink_disappears
--- PASS: TestAccNetworkManagerGlobalNetworkDataSource_basic (16.36s)
=== CONT  TestAccNetworkManagerSiteDataSource_basic
--- PASS: TestAccNetworkManagerLink_disappears (21.92s)
=== CONT  TestAccNetworkManagerLinksDataSource_basic
--- PASS: TestAccNetworkManagerSiteDataSource_basic (21.25s)
=== CONT  TestAccNetworkManagerSitesDataSource_basic
--- PASS: TestAccNetworkManagerSitesDataSource_basic (25.39s)
=== CONT  TestAccNetworkManagerLink_allAttributes
--- PASS: TestAccNetworkManagerLinksDataSource_basic (25.74s)
=== CONT  TestAccNetworkManagerSite_disappears
--- PASS: TestAccNetworkManagerSite_disappears (19.51s)
=== CONT  TestAccNetworkManagerLink_tags
--- PASS: TestAccNetworkManagerLink_allAttributes (43.86s)
=== CONT  TestAccNetworkManagerSite_basic
--- PASS: TestAccNetworkManagerSite_basic (21.00s)
=== CONT  TestAccNetworkManagerSite_tags
--- PASS: TestAccNetworkManagerLink_tags (57.39s)
=== CONT  TestAccNetworkManagerDevice_disappears
--- PASS: TestAccNetworkManagerDevice_disappears (16.84s)
=== CONT  TestAccNetworkManagerSite_description
--- PASS: TestAccNetworkManagerSite_tags (42.31s)
=== CONT  TestAccNetworkManagerDevice_awsLocation
--- PASS: TestAccNetworkManagerSite_description (33.92s)
=== CONT  TestAccNetworkManagerLinkDataSource_basic
--- PASS: TestAccNetworkManagerDevice_awsLocation (38.93s)
=== CONT  TestAccNetworkManagerDevice_allAttributes
--- PASS: TestAccNetworkManagerLinkDataSource_basic (21.44s)
=== CONT  TestAccNetworkManagerLink_basic
--- PASS: TestAccNetworkManagerLink_basic (21.82s)
=== CONT  TestAccNetworkManagerDevice_tags
--- PASS: TestAccNetworkManagerDevice_allAttributes (36.65s)
=== CONT  TestAccNetworkManagerDeviceDataSource_basic
--- PASS: TestAccNetworkManagerDeviceDataSource_basic (18.06s)
=== CONT  TestAccNetworkManagerConnectionsDataSource_basic
--- PASS: TestAccNetworkManagerDevice_tags (46.10s)
=== CONT  TestAccNetworkManagerSite_location
--- PASS: TestAccNetworkManagerConnectionsDataSource_basic (30.51s)
=== CONT  TestAccNetworkManagerDevice_basic
--- PASS: TestAccNetworkManagerSite_location (33.36s)
=== CONT  TestAccNetworkManagerLinkAssociation_disappears
--- PASS: TestAccNetworkManagerDevice_basic (21.36s)
--- PASS: TestAccNetworkManagerLinkAssociation_disappears (21.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	6401.773s
GovCloud
% make testacc TESTS=TestAccNetworkManager PKG=networkmanager ACCTEST_PARALLELISM=1                         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 1 -run='TestAccNetworkManager'  -timeout 180m
=== RUN   TestAccNetworkManagerConnectionDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionDataSource_basic
=== RUN   TestAccNetworkManagerConnection_serial
=== RUN   TestAccNetworkManagerConnection_serial/basic
=== RUN   TestAccNetworkManagerConnection_serial/disappears
=== RUN   TestAccNetworkManagerConnection_serial/tags
=== RUN   TestAccNetworkManagerConnection_serial/descriptionAndLinks
--- PASS: TestAccNetworkManagerConnection_serial (161.69s)
    --- PASS: TestAccNetworkManagerConnection_serial/basic (26.06s)
    --- PASS: TestAccNetworkManagerConnection_serial/disappears (21.09s)
    --- PASS: TestAccNetworkManagerConnection_serial/tags (49.34s)
    --- PASS: TestAccNetworkManagerConnection_serial/descriptionAndLinks (65.20s)
=== RUN   TestAccNetworkManagerConnectionsDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionsDataSource_basic
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/basic
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears
=== RUN   TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears_CustomerGateway
--- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial (1731.79s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/basic (589.06s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears (575.10s)
    --- PASS: TestAccNetworkManagerCustomerGatewayAssociation_serial/disappears_CustomerGateway (567.63s)
=== RUN   TestAccNetworkManagerDeviceDataSource_basic
=== PAUSE TestAccNetworkManagerDeviceDataSource_basic
=== RUN   TestAccNetworkManagerDevice_basic
=== PAUSE TestAccNetworkManagerDevice_basic
=== RUN   TestAccNetworkManagerDevice_disappears
=== PAUSE TestAccNetworkManagerDevice_disappears
=== RUN   TestAccNetworkManagerDevice_tags
=== PAUSE TestAccNetworkManagerDevice_tags
=== RUN   TestAccNetworkManagerDevice_allAttributes
=== PAUSE TestAccNetworkManagerDevice_allAttributes
=== RUN   TestAccNetworkManagerDevice_awsLocation
=== PAUSE TestAccNetworkManagerDevice_awsLocation
=== RUN   TestAccNetworkManagerDevicesDataSource_basic
=== PAUSE TestAccNetworkManagerDevicesDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetworkDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworkDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_basic
=== PAUSE TestAccNetworkManagerGlobalNetwork_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_disappears
=== PAUSE TestAccNetworkManagerGlobalNetwork_disappears
=== RUN   TestAccNetworkManagerGlobalNetwork_tags
=== PAUSE TestAccNetworkManagerGlobalNetwork_tags
=== RUN   TestAccNetworkManagerGlobalNetwork_description
=== PAUSE TestAccNetworkManagerGlobalNetwork_description
=== RUN   TestAccNetworkManagerGlobalNetworksDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworksDataSource_basic
=== RUN   TestAccNetworkManagerLinkAssociation_basic
=== PAUSE TestAccNetworkManagerLinkAssociation_basic
=== RUN   TestAccNetworkManagerLinkAssociation_disappears
=== PAUSE TestAccNetworkManagerLinkAssociation_disappears
=== RUN   TestAccNetworkManagerLinkDataSource_basic
=== PAUSE TestAccNetworkManagerLinkDataSource_basic
=== RUN   TestAccNetworkManagerLink_basic
=== PAUSE TestAccNetworkManagerLink_basic
=== RUN   TestAccNetworkManagerLink_disappears
=== PAUSE TestAccNetworkManagerLink_disappears
=== RUN   TestAccNetworkManagerLink_tags
=== PAUSE TestAccNetworkManagerLink_tags
=== RUN   TestAccNetworkManagerLink_allAttributes
=== PAUSE TestAccNetworkManagerLink_allAttributes
=== RUN   TestAccNetworkManagerLinksDataSource_basic
=== PAUSE TestAccNetworkManagerLinksDataSource_basic
=== RUN   TestAccNetworkManagerSiteDataSource_basic
=== PAUSE TestAccNetworkManagerSiteDataSource_basic
=== RUN   TestAccNetworkManagerSite_basic
=== PAUSE TestAccNetworkManagerSite_basic
=== RUN   TestAccNetworkManagerSite_disappears
=== PAUSE TestAccNetworkManagerSite_disappears
=== RUN   TestAccNetworkManagerSite_tags
=== PAUSE TestAccNetworkManagerSite_tags
=== RUN   TestAccNetworkManagerSite_description
=== PAUSE TestAccNetworkManagerSite_description
=== RUN   TestAccNetworkManagerSite_location
=== PAUSE TestAccNetworkManagerSite_location
=== RUN   TestAccNetworkManagerSitesDataSource_basic
=== PAUSE TestAccNetworkManagerSitesDataSource_basic
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic
=== RUN   TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears
--- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial (2401.08s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears_ConnectPeer (833.89s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/basic (776.94s)
    --- PASS: TestAccNetworkManagerTransitGatewayConnectPeerAssociation_serial/disappears (790.25s)
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/basic
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/disappears
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/disappears_TransitGateway
=== RUN   TestAccNetworkManagerTransitGatewayRegistration_serial/crossRegion
--- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial (1122.58s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/basic (294.34s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears (284.92s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/disappears_TransitGateway (276.23s)
    --- PASS: TestAccNetworkManagerTransitGatewayRegistration_serial/crossRegion (267.10s)
=== CONT  TestAccNetworkManagerConnectionDataSource_basic
--- PASS: TestAccNetworkManagerConnectionDataSource_basic (23.92s)
=== CONT  TestAccNetworkManagerLinkAssociation_basic
--- PASS: TestAccNetworkManagerLinkAssociation_basic (21.54s)
=== CONT  TestAccNetworkManagerSitesDataSource_basic
--- PASS: TestAccNetworkManagerSitesDataSource_basic (18.40s)
=== CONT  TestAccNetworkManagerSite_location
--- PASS: TestAccNetworkManagerSite_location (30.08s)
=== CONT  TestAccNetworkManagerLink_allAttributes
--- PASS: TestAccNetworkManagerLink_allAttributes (33.23s)
=== CONT  TestAccNetworkManagerLink_tags
--- PASS: TestAccNetworkManagerLink_tags (58.86s)
=== CONT  TestAccNetworkManagerLink_disappears
--- PASS: TestAccNetworkManagerLink_disappears (17.48s)
=== CONT  TestAccNetworkManagerLinksDataSource_basic
--- PASS: TestAccNetworkManagerLinksDataSource_basic (18.99s)
=== CONT  TestAccNetworkManagerLink_basic
--- PASS: TestAccNetworkManagerLink_basic (21.41s)
=== CONT  TestAccNetworkManagerSite_description
--- PASS: TestAccNetworkManagerSite_description (29.89s)
=== CONT  TestAccNetworkManagerSite_tags
--- PASS: TestAccNetworkManagerSite_tags (41.94s)
=== CONT  TestAccNetworkManagerLinkDataSource_basic
--- PASS: TestAccNetworkManagerLinkDataSource_basic (18.45s)
=== CONT  TestAccNetworkManagerLinkAssociation_disappears
--- PASS: TestAccNetworkManagerLinkAssociation_disappears (18.79s)
=== CONT  TestAccNetworkManagerSiteDataSource_basic
--- PASS: TestAccNetworkManagerSiteDataSource_basic (18.49s)
=== CONT  TestAccNetworkManagerSite_disappears
--- PASS: TestAccNetworkManagerSite_disappears (15.24s)
=== CONT  TestAccNetworkManagerDevicesDataSource_basic
--- PASS: TestAccNetworkManagerDevicesDataSource_basic (16.95s)
=== CONT  TestAccNetworkManagerGlobalNetwork_tags
--- PASS: TestAccNetworkManagerGlobalNetwork_tags (39.61s)
=== CONT  TestAccNetworkManagerGlobalNetwork_disappears
--- PASS: TestAccNetworkManagerGlobalNetwork_disappears (12.05s)
=== CONT  TestAccNetworkManagerGlobalNetworksDataSource_basic
--- PASS: TestAccNetworkManagerGlobalNetworksDataSource_basic (15.76s)
=== CONT  TestAccNetworkManagerGlobalNetwork_basic
--- PASS: TestAccNetworkManagerGlobalNetwork_basic (18.11s)
=== CONT  TestAccNetworkManagerGlobalNetwork_description
--- PASS: TestAccNetworkManagerGlobalNetwork_description (27.52s)
=== CONT  TestAccNetworkManagerGlobalNetworkDataSource_basic
--- PASS: TestAccNetworkManagerGlobalNetworkDataSource_basic (15.22s)
=== CONT  TestAccNetworkManagerSite_basic
--- PASS: TestAccNetworkManagerSite_basic (19.59s)
=== CONT  TestAccNetworkManagerDevice_disappears
--- PASS: TestAccNetworkManagerDevice_disappears (15.29s)
=== CONT  TestAccNetworkManagerDevice_allAttributes
--- PASS: TestAccNetworkManagerDevice_allAttributes (31.63s)
=== CONT  TestAccNetworkManagerDevice_tags
--- PASS: TestAccNetworkManagerDevice_tags (42.64s)
=== CONT  TestAccNetworkManagerDeviceDataSource_basic
--- PASS: TestAccNetworkManagerDeviceDataSource_basic (16.69s)
=== CONT  TestAccNetworkManagerDevice_awsLocation
--- PASS: TestAccNetworkManagerDevice_awsLocation (36.88s)
=== CONT  TestAccNetworkManagerConnectionsDataSource_basic
--- PASS: TestAccNetworkManagerConnectionsDataSource_basic (24.21s)
=== CONT  TestAccNetworkManagerDevice_basic
--- PASS: TestAccNetworkManagerDevice_basic (19.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	6159.047s

@ewbankkit
Copy link
Contributor

@Omarimcblack Thanks for the contribution 🎉 👏.

@Omarimcblack
Copy link
Contributor Author

@Omarimcblack Thanks for the contribution 🎉 👏.

Thanks for finishing this off @ewbankkit 🎉

@ewbankkit ewbankkit merged commit d3e7add into hashicorp:main Mar 14, 2022
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 14, 2022
@Omarimcblack Omarimcblack deleted the new_feature_global_network branch March 15, 2022 16:13
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/networkmanager Issues and PRs that pertain to the networkmanager service. size/XL Managed by automation to categorize the size of a PR. size/XXL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Feature: AWS Network Manager for Transit Gateways
9 participants