Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_availability_zones: Fix group_names attribute to be Computed instead of Optional #14412

Merged
merged 1 commit into from
Jul 31, 2020
Merged

data-source/aws_availability_zones: Fix group_names attribute to be Computed instead of Optional #14412

merged 1 commit into from
Jul 31, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 30, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14405

Release note for CHANGELOG:

* data-source/aws_availability_zones: Prevent unexpected plan output every apply with `group_names` attribute

Output from acceptance testing:

--- PASS: TestAccAWSAvailabilityZones_Filter (7.67s)
--- PASS: TestAccAWSAvailabilityZones_basic (7.83s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (7.88s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (7.88s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (9.35s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (9.41s)

@bflad
data-source/aws_availability_zones: Fix group_names attribute to be C…
08066b6 
…omputed instead of Optional

Reference: #14405

Output from acceptance testing:

```
--- PASS: TestAccAWSAvailabilityZones_Filter (7.67s)
--- PASS: TestAccAWSAvailabilityZones_basic (7.83s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (7.88s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (7.88s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (9.35s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (9.41s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Jul 30, 2020
@bflad bflad requested a review from a team July 30, 2020 16:06
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 30, 2020
@bflad bflad mentioned this pull request Jul 30, 2020
Closed
anGie44
anGie44 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v3.1.0 milestone Jul 31, 2020
@bflad bflad merged commit d3c1160 into master Jul 31, 2020
@bflad bflad deleted the b-aws_availability_zones-group_names-Computed branch July 31, 2020 02:24
bflad added a commit that referenced this pull request Jul 31, 2020
@bflad
Update CHANGELOG for #14412
1e32674
@bflad bflad mentioned this pull request Jul 31, 2020
Merged
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@icollar icollar mentioned this pull request Aug 10, 2020
Closed
@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

aws_availability_zones started proposing changes on each apply
2 participants
@bflad @anGie44