r/aws_customer_gateway: Add device_name attribute

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14346

Release note for CHANGELOG:

r/aws_customer_gateway: Add device_name attribute
d/aws_customer_gateway: Add device_name attribute

Output from acceptance testing:

# For r/aws_customer_gateway
$ make testacc TESTARGS='-run=TestAccAWSCustomerGateway_deviceName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCustomerGateway_deviceName -timeout 120m
=== RUN   TestAccAWSCustomerGateway_deviceName
=== PAUSE TestAccAWSCustomerGateway_deviceName
=== CONT  TestAccAWSCustomerGateway_deviceName
--- PASS: TestAccAWSCustomerGateway_deviceName (48.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.207s

# For d/aws_customer_gateway
$  make testacc TESTARGS='-run=TestAccAWSCustomerGatewayDataSource_ID'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCustomerGatewayDataSource_ID -timeout 120m
=== RUN   TestAccAWSCustomerGatewayDataSource_ID
=== PAUSE TestAccAWSCustomerGatewayDataSource_ID
=== CONT  TestAccAWSCustomerGatewayDataSource_ID
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (44.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.584s
...

Thank you for your review!

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCustomerGateway_\|TestAccAWSCustomerGatewayDataSource_' ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSCustomerGateway_\|TestAccAWSCustomerGatewayDataSource_ -timeout 120m
=== RUN   TestAccAWSCustomerGatewayDataSource_Filter
=== PAUSE TestAccAWSCustomerGatewayDataSource_Filter
=== RUN   TestAccAWSCustomerGatewayDataSource_ID
=== PAUSE TestAccAWSCustomerGatewayDataSource_ID
=== RUN   TestAccAWSCustomerGateway_basic
=== PAUSE TestAccAWSCustomerGateway_basic
=== RUN   TestAccAWSCustomerGateway_tags
=== PAUSE TestAccAWSCustomerGateway_tags
=== RUN   TestAccAWSCustomerGateway_similarAlreadyExists
=== PAUSE TestAccAWSCustomerGateway_similarAlreadyExists
=== RUN   TestAccAWSCustomerGateway_deviceName
=== PAUSE TestAccAWSCustomerGateway_deviceName
=== RUN   TestAccAWSCustomerGateway_disappears
=== PAUSE TestAccAWSCustomerGateway_disappears
=== RUN   TestAccAWSCustomerGateway_4ByteAsn
=== PAUSE TestAccAWSCustomerGateway_4ByteAsn
=== CONT  TestAccAWSCustomerGatewayDataSource_Filter
=== CONT  TestAccAWSCustomerGateway_deviceName
=== CONT  TestAccAWSCustomerGateway_4ByteAsn
=== CONT  TestAccAWSCustomerGateway_disappears
    resource_aws_customer_gateway_test.go:158: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCustomerGateway_disappears (28.01s)
=== CONT  TestAccAWSCustomerGateway_tags
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (32.08s)
=== CONT  TestAccAWSCustomerGateway_similarAlreadyExists
--- PASS: TestAccAWSCustomerGateway_deviceName (36.85s)
=== CONT  TestAccAWSCustomerGateway_basic
--- PASS: TestAccAWSCustomerGateway_4ByteAsn (37.03s)
=== CONT  TestAccAWSCustomerGatewayDataSource_ID
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (30.50s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (40.91s)
--- PASS: TestAccAWSCustomerGateway_tags (64.89s)
--- PASS: TestAccAWSCustomerGateway_basic (60.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	97.638s

[bflad]

Looks great, thank you, @shuheiktgw 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSCustomerGateway_disappears (23.96s)
--- PASS: TestAccAWSCustomerGateway_4ByteAsn (27.20s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (27.34s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (27.47s)
--- PASS: TestAccAWSCustomerGateway_deviceName (28.85s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (33.20s)
--- PASS: TestAccAWSCustomerGateway_tags (49.16s)
--- PASS: TestAccAWSCustomerGateway_basic (50.72s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSCustomerGateway_disappears (27.96s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (30.89s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (32.31s)
--- PASS: TestAccAWSCustomerGateway_deviceName (34.94s)
--- PASS: TestAccAWSCustomerGateway_4ByteAsn (34.94s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (39.80s)
--- PASS: TestAccAWSCustomerGateway_basic (59.86s)
--- PASS: TestAccAWSCustomerGateway_tags (61.27s)

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!