Issue-1146 part a

[c4po]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1146

Release note for CHANGELOG:

* resource `aws_emr_cluster`: add `master_instance_fleet` and `core_instance_fleet`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEMRCluster_instance_fleet'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRCluster_instance_fleet -timeout 120m
=== RUN   TestAccAWSEMRCluster_instance_fleet
 --- PASS: TestAccAWSEMRCluster_instance_fleet (507.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	507.614s

$ make testacc TESTARGS='-run=TestAccAWSEMRCluster_instance_fleet_master_only'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRCluster_instance_fleet_master_only -timeout 120m
=== RUN   TestAccAWSEMRCluster_instance_fleet_master_only
=== PAUSE TestAccAWSEMRCluster_instance_fleet_master_only
=== CONT  TestAccAWSEMRCluster_instance_fleet_master_only
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (476.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	476.506s

[bflad]

Hi @c4po 👋 Thank you so much for splitting up the pull requests -- this is off to a good start. Please see the below initial feedback and reach out if you have any questions or do not have time to implement the requested items. 👍

[bflad]

I think these are the last few things before we can get this initial support merged in -- thanks!

[bflad]

Looks good, thank you @c4po 🚀

Output from acceptance testing (failure unrelated):

--- FAIL: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (761.58s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (389.66s)
--- PASS: TestAccAWSEMRCluster_basic (421.31s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1315.25s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (488.41s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (530.87s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1073.94s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (578.27s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (822.02s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (885.45s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (546.87s)
--- PASS: TestAccAWSEMRCluster_disappears (443.96s)
--- PASS: TestAccAWSEMRCluster_ebs_config (555.62s)
--- PASS: TestAccAWSEMRCluster_instance_fleet (454.47s)
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (429.68s)
--- PASS: TestAccAWSEMRCluster_keepJob (390.32s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (520.68s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (949.21s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1074.24s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (976.43s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (930.00s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (780.90s)
--- PASS: TestAccAWSEMRCluster_s3Logging (528.25s)
--- PASS: TestAccAWSEMRCluster_security_config (687.55s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (493.95s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (543.97s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (896.25s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (493.67s)
--- PASS: TestAccAWSEMRCluster_tags (820.00s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (614.80s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (946.47s)

[ghost]

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!