Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ebs_volume io2 support #14894

Merged
merged 5 commits into from
Aug 28, 2020
Merged

aws_ebs_volume io2 support #14894

merged 5 commits into from
Aug 28, 2020

Conversation

nikhil-goenka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #14817

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEBSVolume'
--- SKIP: TestAccAWSEBSVolume_outpost (5.58s)
--- PASS: TestAccAWSEBSVolume_InvalidIopsForType (52.15s)
--- PASS: TestAccAWSEBSVolume_disappears (134.14s)
--- PASS: TestAccAWSEBSVolume_NoIops (147.67s)
--- PASS: TestAccAWSEBSVolume_basic (155.59s)
--- PASS: TestAccAWSEBSVolume_multiAttach (160.93s)
--- PASS: TestAccAWSEBSVolume_withTags (162.88s)
--- PASS: TestAccAWSEBSVolume_kmsKey (169.59s)
--- PASS: TestAccAWSEBSVolume_updateType (221.98s)
--- PASS: TestAccAWSEBSVolume_updateSize (224.16s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io2 (230.68s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io1 (230.75s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (342.50s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       342.879s
...

@nikhil-goenka nikhil-goenka requested a review from a team August 28, 2020 18:03
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 28, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Aug 28, 2020
@nikhil-goenka nikhil-goenka changed the title Support for resource aws ebs volume io2 aws_ebs_volume io2 support Aug 28, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 28, 2020
@nikhil-goenka @bflad
Update aws/resource_aws_ebs_volume.go
eb5ee8d 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@bflad bflad added this to the v3.5.0 milestone Aug 28, 2020
bflad
bflad approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks so much @nikhil-goenka 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEBSVolume_InvalidIopsForType (13.80s)
--- PASS: TestAccAWSEBSVolume_disappears (40.14s)
--- PASS: TestAccAWSEBSVolume_NoIops (46.08s)
--- PASS: TestAccAWSEBSVolume_withTags (50.69s)
--- PASS: TestAccAWSEBSVolume_multiAttach (52.17s)
--- PASS: TestAccAWSEBSVolume_kmsKey (52.32s)
--- PASS: TestAccAWSEBSVolume_basic (52.95s)
--- PASS: TestAccAWSEBSVolume_updateType (77.19s)
--- PASS: TestAccAWSEBSVolume_updateSize (77.90s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io1 (79.17s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io2 (79.14s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (228.65s)

@bflad bflad merged commit c334cfd into hashicorp:master Aug 28, 2020
bflad added a commit that referenced this pull request Aug 28, 2020
@bflad
Update CHANGELOG for #14894
b94d35b
@nikhil-goenka nikhil-goenka deleted the support-for-resource_aws_ebs_volume-io2 branch September 3, 2020 18:38
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

resource/aws_ebs_volume: support io2 volume type
2 participants
@nikhil-goenka @bflad