Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_vpc_endpoint_service: Accept service_type as argument #15467

Merged
merged 1 commit into from
Oct 8, 2020
Merged

data-source/aws_vpc_endpoint_service: Accept service_type as argument #15467

merged 1 commit into from
Oct 8, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 3, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

data-source/aws_vpc_endpoint_service: Accept `service_type` as argument

Allow practitioners to prevent the following error in certain environments:

Error: multiple VPC Endpoint Services matched; use additional constraints to reduce matches to a single VPC Endpoint Service

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (13.90s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (13.91s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (14.00s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (14.69s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (243.09s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (243.14s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (253.55s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (18.12s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (18.20s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (18.66s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (18.67s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (236.92s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (258.50s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (259.55s)

@bflad
data-source/aws_vpc_endpoint_service: Accept service_type as argument
a2cb192 
Allow practitioners to prevent the following error in certain environments:

```
Error: multiple VPC Endpoint Services matched; use additional constraints to reduce matches to a single VPC Endpoint Service
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (13.90s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (13.91s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (14.00s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (14.69s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (243.09s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (243.14s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (253.55s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (18.12s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (18.20s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (18.66s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (18.67s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (236.92s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (258.50s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (259.55s)
```
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 3, 2020
@bflad bflad requested a review from a team October 3, 2020 16:39
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 3, 2020
@gdavison gdavison self-assigned this Oct 7, 2020
gdavison
gdavison approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (44.06s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (46.77s)
--- PASS: TestAccAWSProvider_Region_AwsChina (46.82s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (54.30s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (54.87s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (55.47s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (56.25s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (55.99s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (56.03s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (56.38s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (55.97s)
--- PASS: TestAccAWSProvider_Endpoints (56.11s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (57.12s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Gateway (56.30s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (56.22s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_ServiceType_Interface (56.88s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (244.61s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (294.25s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (315.69s)

@gdavison gdavison merged commit b7c6594 into master Oct 8, 2020
@gdavison gdavison deleted the f-aws_vpc_endpoint_service-service_type-argument branch October 8, 2020 18:52
gdavison added a commit that referenced this pull request Oct 8, 2020
@gdavison
Update CHANGELOG for #15467
9379abe
@gdavison gdavison added this to the v3.10.0 milestone Oct 8, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @gdavison