r/glue_trigger - add support for security_configuration and notification_property for actions + refactor tests and waiters

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13826

Release note for CHANGELOG:

resource_aws_glue_trigger - add plan time validation to `name`
resource_aws_glue_trigger - add `security_configuration` and `notification_property` arguments to `actions` block

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueTrigger_'
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (70.24s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (75.44s)
--- PASS: TestAccAWSGlueTrigger_disappears (77.95s)
--- PASS: TestAccAWSGlueTrigger_basic (83.26s)
--- PASS: TestAccAWSGlueTrigger_Description (106.62s)
--- PASS: TestAccAWSGlueTrigger_Predicate (142.72s)
--- PASS: TestAccAWSGlueTrigger_Crawler (142.77s)
--- PASS: TestAccAWSGlueTrigger_Schedule (142.83s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (144.10s)
--- PASS: TestAccAWSGlueTrigger_Tags (153.16s)
--- PASS: TestAccAWSGlueTrigger_Enabled (212.60s)

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueTrigger_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueTrigger_ -timeout 120m
=== RUN   TestAccAWSGlueTrigger_basic
=== PAUSE TestAccAWSGlueTrigger_basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_Tags
=== PAUSE TestAccAWSGlueTrigger_Tags
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== RUN   TestAccAWSGlueTrigger_actions_notify
=== PAUSE TestAccAWSGlueTrigger_actions_notify
=== RUN   TestAccAWSGlueTrigger_actions_securityConfig
=== PAUSE TestAccAWSGlueTrigger_actions_securityConfig
=== RUN   TestAccAWSGlueTrigger_disappears
=== PAUSE TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_basic
=== CONT  TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_actions_securityConfig
=== CONT  TestAccAWSGlueTrigger_Schedule
=== CONT  TestAccAWSGlueTrigger_actions_notify
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_Tags
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_Description
=== CONT  TestAccAWSGlueTrigger_Crawler
--- PASS: TestAccAWSGlueTrigger_disappears (67.08s)
--- PASS: TestAccAWSGlueTrigger_basic (74.82s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (76.46s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (76.85s)
--- PASS: TestAccAWSGlueTrigger_Description (111.56s)
--- PASS: TestAccAWSGlueTrigger_Tags (130.87s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (131.93s)
--- PASS: TestAccAWSGlueTrigger_Predicate (146.54s)
--- PASS: TestAccAWSGlueTrigger_Schedule (147.11s)
--- PASS: TestAccAWSGlueTrigger_Crawler (152.37s)
--- PASS: TestAccAWSGlueTrigger_Enabled (165.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	165.986s

[breathingdust]

LGTM 🚀 Thanks @DrFaust92

Note failure in GovCloud for the TestAccAWSGlueTrigger_WorkflowName. This is unrelated to this PR, and is tracked here #16025

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSGlueTrigger_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueTrigger_ -timeout 120m
=== RUN   TestAccAWSGlueTrigger_basic
=== PAUSE TestAccAWSGlueTrigger_basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_Tags
=== PAUSE TestAccAWSGlueTrigger_Tags
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== RUN   TestAccAWSGlueTrigger_actions_notify
=== PAUSE TestAccAWSGlueTrigger_actions_notify
=== RUN   TestAccAWSGlueTrigger_actions_securityConfig
=== PAUSE TestAccAWSGlueTrigger_actions_securityConfig
=== RUN   TestAccAWSGlueTrigger_disappears
=== PAUSE TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_basic
=== CONT  TestAccAWSGlueTrigger_Tags
=== CONT  TestAccAWSGlueTrigger_actions_securityConfig
=== CONT  TestAccAWSGlueTrigger_Crawler
=== CONT  TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_actions_notify
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_Schedule
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_Description
--- PASS: TestAccAWSGlueTrigger_basic (25.73s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (41.70s)
--- PASS: TestAccAWSGlueTrigger_Description (55.23s)
--- PASS: TestAccAWSGlueTrigger_disappears (67.42s)
--- PASS: TestAccAWSGlueTrigger_Predicate (93.75s)
--- PASS: TestAccAWSGlueTrigger_Schedule (97.26s)
--- PASS: TestAccAWSGlueTrigger_Crawler (102.82s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (111.12s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (140.28s)
--- PASS: TestAccAWSGlueTrigger_Tags (143.55s)
--- PASS: TestAccAWSGlueTrigger_Enabled (176.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	177.760s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSGlueTrigger_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueTrigger_ -timeout 120m
=== RUN   TestAccAWSGlueTrigger_basic
=== PAUSE TestAccAWSGlueTrigger_basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_Tags
=== PAUSE TestAccAWSGlueTrigger_Tags
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== RUN   TestAccAWSGlueTrigger_actions_notify
=== PAUSE TestAccAWSGlueTrigger_actions_notify
=== RUN   TestAccAWSGlueTrigger_actions_securityConfig
=== PAUSE TestAccAWSGlueTrigger_actions_securityConfig
=== RUN   TestAccAWSGlueTrigger_disappears
=== PAUSE TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_basic
=== CONT  TestAccAWSGlueTrigger_Tags
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_Schedule
=== CONT  TestAccAWSGlueTrigger_actions_notify
=== CONT  TestAccAWSGlueTrigger_actions_securityConfig
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_Description
=== CONT  TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_Crawler
2020/11/04 11:14:54 [DEBUG] Reading Glue Trigger: {
  Name: "tf-acc-test-1556433196264034298"
}
=== CONT  TestAccAWSGlueTrigger_WorkflowName
    resource_aws_glue_trigger_test.go:343: Step 1/2 error: Check failed: Check 2/2 error: aws_glue_trigger.test: Attribute 'workflow_name' expected "tf-acc-test-6883241827287136203", got ""
--- FAIL: TestAccAWSGlueTrigger_WorkflowName (65.17s)
--- PASS: TestAccAWSGlueTrigger_Description (67.23s)
--- PASS: TestAccAWSGlueTrigger_Crawler (70.54s)
--- PASS: TestAccAWSGlueTrigger_Tags (76.11s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (80.11s)
--- PASS: TestAccAWSGlueTrigger_Enabled (88.73s)
--- PASS: TestAccAWSGlueTrigger_disappears (114.77s)
--- PASS: TestAccAWSGlueTrigger_Predicate (123.50s)
--- PASS: TestAccAWSGlueTrigger_basic (123.77s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (134.46s)
--- PASS: TestAccAWSGlueTrigger_Schedule (156.77s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	158.349s
FAIL
make: *** [testacc] Error 1

[ghost]

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!