Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_notebook_instance - support additional repos #15830

Merged
merged 2 commits into from
Oct 29, 2020
Merged

r/sagemaker_notebook_instance - support additional repos #15830

merged 2 commits into from
Oct 29, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_sagemaker_notebook_instance - add support for `additional_code_repositories`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1523.50s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (429.08s)

@DrFaust92 DrFaust92 requested a review from a team October 25, 2020 09:40
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/sagemaker Issues and PRs that pertain to the sagemaker service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 25, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 25, 2020
@DrFaust92 DrFaust92 force-pushed the r/sagemaker_notebook_instance_additional_repos branch from bdafee3 to 92a7f27 Compare October 27, 2020 18:05
ewbankkit
ewbankkit approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (316.79s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1548.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1548.169s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (418.11s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1451.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1452.923s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (318.54s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1377.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1379.242s

@breathingdust breathingdust added this to the v3.13.0 milestone Oct 29, 2020
@breathingdust breathingdust merged commit ea8e1b5 into hashicorp:master Oct 29, 2020
breathingdust added a commit that referenced this pull request Oct 29, 2020
@breathingdust
Update CHANGELOG.md for #15830
2ff84a9
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
@DrFaust92 DrFaust92 deleted the r/sagemaker_notebook_instance_additional_repos branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @breathingdust @ewbankkit