Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Binary Resource on API Gateway forces new resource #1594

Closed
SmithKevin opened this issue Sep 5, 2017 · 2 comments · Fixed by #1600
Closed

Adding Binary Resource on API Gateway forces new resource #1594

SmithKevin opened this issue Sep 5, 2017 · 2 comments · Fixed by #1600
Labels
bug Addresses a defect in current functionality.

Comments

@SmithKevin
Copy link

Anyone have any insight on why adding a new Binary Resource forces a new resource? Since this is the root of the gateway it causes Terraform to destroy and rebuild the entire gateway which is potentially hundreds of resources. The AWS CLI and console can add it without any additional changes.
http://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-payload-encodings-configure-with-control-service-api.html

Relevant PR is here hashicorp/terraform#10776
Line of Code:
https://github.com/terraform-providers/terraform-provider-aws/blob/6c64d1569780b0c83e82bb74ca0fa7fd9a562c94/aws/resource_aws_api_gateway_rest_api.go#L37

Would removing this line be enough or do I need to write additional code to support this patch request?

@Ninir Ninir added the bug Addresses a defect in current functionality. label Sep 6, 2017
@Ninir
Copy link
Contributor

Ninir commented Sep 6, 2017

Hey @SmithKevin

You are 100% right, updates should be possible. I assume it was not doable previously, and it is now.
Just pushed a code update for that :)

Sorry for the noise!

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
2 participants