Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds launch_template to aws_autoscaling_group data source #16297

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

gdavison
Copy link
Contributor

Adds launch_template to aws_autoscaling_group data source.

Closes #16289

Release note for CHANGELOG:

* data-source/aws_autoscaling_group: Adds `launch_template` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsAutoScalingGroupDataSource_'

--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (48.47s)
--- PASS: TestAccAwsAutoScalingGroupDataSource_launchTemplate (68.97s)

@gdavison gdavison requested a review from a team as a code owner November 19, 2020 00:12
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 19, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 19, 2020
@anGie44 anGie44 self-assigned this Dec 2, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 (aside from merge conflict in test file)

Output of acceptance tests:

--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (29.18s)
--- PASS: TestAccAwsAutoScalingGroupDataSource_launchTemplate (32.99s)

resource "aws_launch_template" "test" {
name_prefix = "test"
image_id = data.aws_ami.test_ami.id
instance_type = "t2.micro"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need to avoid the hardcoded instance type here, but we could also use the testAccAvailableEc2InstanceTypeForRegion("t3.micro", "t2.micro") config and ref here

@gdavison gdavison force-pushed the f-data-asg-add-launchtemplate branch from af05bbc to 1ef6047 Compare December 14, 2020 20:17
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 14, 2020
@gdavison gdavison merged commit 9c54b4e into master Dec 14, 2020
@gdavison gdavison deleted the f-data-asg-add-launchtemplate branch December 14, 2020 20:27
@github-actions github-actions bot added this to the v3.22.0 milestone Dec 14, 2020
gdavison added a commit that referenced this pull request Dec 14, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add launch_template to aws_autoscaling_group data source
3 participants