Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_instance: Automatically retry instance restart on eventual consistency error during instance_type in-place update #16443

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 25, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16433

Release note for CHANGELOG:

* resource/aws_instance: Automatically retry instance restart on eventual consistency error during `instance_type` in-place update

Given that EC2 is eventually consistent in other places and AWS Support is recommending that behavior here as a cause, insert best effort retry logic.

Output from acceptance testing:

--- PASS: TestAccAWSInstance_changeInstanceType (178.65s)

…ventual consistency error

Reference: #16433

Given that EC2 is eventually consistent in other places and AWS Support is recommending that behavior here as a cause, insert best effort retry logic.

Output from acceptance testing:

```
--- PASS: TestAccAWSInstance_changeInstanceType (178.65s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Nov 25, 2020
@bflad bflad requested a review from a team as a code owner November 25, 2020 20:37
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Nov 25, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry logic LGTM 👍

@bflad bflad added this to the v3.20.0 milestone Dec 3, 2020
@bflad bflad merged commit db22cd4 into master Dec 3, 2020
@bflad bflad deleted the b-aws_instance-instance_type-eventual-consistency branch December 3, 2020 15:01
bflad added a commit that referenced this pull request Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform failed during modify ec2 instance_type
2 participants