Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_storagegateway_gateway SMB file_share_visibility support #16701

Closed
dthvt opened this issue Dec 10, 2020 · 2 comments
Closed

aws_storagegateway_gateway SMB file_share_visibility support #16701

dthvt opened this issue Dec 10, 2020 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service.

Comments

@dthvt
Copy link
Contributor

dthvt commented Dec 10, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support for file_share_visibility within SMB settings on an AWS Storage Gateway.

New or Affected Resource(s)

  • aws_storagegateway_gateway

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
resource "aws_storagegateway_gateway" "test" {
  # ....
  smb_file_share_visibility = true
}

References

@dthvt dthvt added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 10, 2020
@ghost ghost added the service/storagegateway Issues and PRs that pertain to the storagegateway service. label Dec 10, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 10, 2020
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Dec 10, 2020
@dthvt
Copy link
Contributor Author

dthvt commented Mar 25, 2021

Fixed by #18076

@dthvt dthvt closed this as completed Mar 25, 2021
@ghost
Copy link

ghost commented Apr 24, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants