Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource - QLDB Data Streams #17471

Closed
frumpled opened this issue Feb 4, 2021 · 6 comments · Fixed by #19297
Closed

New Resource - QLDB Data Streams #17471

frumpled opened this issue Feb 4, 2021 · 6 comments · Fixed by #19297
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/qldb Issues and PRs that pertain to the qldb service.
Milestone

Comments

@frumpled
Copy link
Contributor

frumpled commented Feb 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

From the docs:

  • The QLDB data stream is "a stream of journal data from your ledger to Amazon Kinesis Data Streams."
  • "The QLDB stream captures every document revision that is committed to your journal and sends it to a Kinesis data stream."
  • "Every QLDB journal stream is a subresource of a ledger and is uniquely identified by an Amazon Resource Name (ARN)."

A key thing to note here is that a QLDB instance can have many data streams.

New or Affected Resource(s)

  • aws_qldb_stream

Potential Terraform Configuration

resource "aws_qldb_stream" "some_ledger_data_stream" {
  ledger_name = "source-ledger-name"
  stream_name = "my-stream-name"
  destination_stream = "some-destination-kinesis-arn"
  start_date_time = ""
  end_data_time = "" # optional
  iam-role = "iam-role-arn"
  tags = {}
}

References

@frumpled frumpled added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 4, 2021
@ghost ghost added the service/qldb Issues and PRs that pertain to the qldb service. label Feb 4, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 4, 2021
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 5, 2021
@ewbankkit
Copy link
Contributor

The resource should probably be named aws_qldb_stream as that's how it's named in the AWS API and ARN.

@frumpled
Copy link
Contributor Author

frumpled commented Feb 5, 2021

Good point, I updated that 😅

@frumpled
Copy link
Contributor Author

Seems like there isn't much interest in this, so I will make an attempt at this myself 😅
If someone else is already working on this or there's a rush to get this out, please reach out 😄

@frumpled
Copy link
Contributor Author

frumpled commented May 10, 2021

After doing some digging, it looks like the potential terraform configuration should look more like this:

resource "aws_qldb_stream" "sample-ledger-stream" {
  ledger_name          = "existing-ledger-name"
  stream_name          = "sample-ledger-stream"
  role_arn             = "arn:aws:iam::xxxxxxxxxxxx:role/service-role/sample-role-arn"
  inclusive_start_time = "2021-01-01T00:00:00Z"

  kinesis_configuration = {
    aggegation_enabled = false
    stream_arn         = "arn:aws:kinesis:us-east-1:xxxxxxxxxxxx:stream/example-kinesis-stream"
  }

  tags = {
    "example" = "tag"
  }
}

Lmk if anyone has thoughts on this 🤔

@github-actions github-actions bot added this to the v4.10.0 milestone Apr 13, 2022
@github-actions
Copy link

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/qldb Issues and PRs that pertain to the qldb service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants