aws_ses_reciept_rule validation isn't accurate, causing plan/apply failures for things AWS would be fine with

[joshsleeper]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

$ terraform -v
Terraform v0.12.26
+ provider.aws v3.28.0

Affected Resource(s)

• aws_ses_receipt_rule

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_ses_receipt_rule" "example" {
  name = "my.custom.domain"

  # snipped rest of config, since the regex error applies
  # to any properly configured resource of this type
}

Expected Behavior

it should plan without issue

Actual Behavior

Error: invalid value for name (must contain only alphanumeric, underscore, and hyphen characters)

  on ses.tf line 2, in resource "aws_ses_receipt_rule" "example":
 137:   name = "my.custom.domain"

Steps to Reproduce

1. terraform plan

References

• r/ses_receipt_rule - add arn attribute + validations #13960
  • the non-exhaustive regex was added in this PR, specifically the line linked below:
  • https://github.com/hashicorp/terraform-provider-aws/pull/13960/files#diff-22e529e720e3c2f669137855c123b95e70b6829e6ddad3b16cbd7aa0c4cef006R40
• screencapture from the AWS console, showing that . (period) characters are allowed
  • 

[joshsleeper]

pretty sure it's just a matter of changing the regex in the referenced code like so:

- ^[0-9a-zA-Z_-]+$
+ ^[0-9a-zA-Z._-]+$

[anGie44]

HI @joshsleeper, thank you for raising this issue and apologies for the new behavior! you're definitely correct, the regex should account for . as Step 6.a. in the aws dev guide mentions the name can include such chars.

[joshsleeper]

you're very welcome, thanks for helping maintain an infinitely useful terraform provider! 😆
probably worth double-checking the other regexes added in that same PR, just in case anything else slipped through.

[DrFaust92]

My bad, i went by https://docs.aws.amazon.com/ses/latest/APIReference/API_ReceiptRule.html and it doesnt cover .. ill open a PR to fix this unless @joshsleeper is willing to try.

[joshsleeper]

well hell, hard to blame you for the mistake when the docs lie! 😆
lemme see if I can open a PR real quick to fix just that one~

[ghost]

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!