Use getOkExists to retrieve associate_public_ip_address as false. #17695

rick-masters · 2021-02-19T01:06:01Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1484.
Closes #13137.
Closes #25043.
Closes #25083.

Output from acceptance testing:

--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (18.80s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (19.62s)
--- PASS: TestAccAWSLaunchConfiguration_metadataOptions (20.64s)
--- PASS: TestAccAWSLaunchConfiguration_userData (32.96s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_ebsNoDevice (17.50s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (18.93s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (22.92s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (18.72s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (21.64s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (36.04s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (38.92s)
--- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (27.35s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (33.31s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_VolumeSize (53.46s)
--- PASS: TestAccAWSLaunchConfiguration_basic (38.47s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_AmiDisappears (359.20s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (23.36s)

aws/resource_aws_launch_configuration.go

rick-masters · 2021-02-19T14:42:19Z

Thank you for taking a look at this and for the suggestion. I just tested this and unfortunately it leads to the opposite problem - an explicit "false" will be provided when instead the instance should pick up the default from the subnet. So the instance does not get a public IP.

If the setting is not provided, there is no reason to override the subnet setting. That is the current behavior. Basically, there really is no default for this setting.

So, the presence of the Default of false in the schema is also suspect here. That default is not present in resource_aws_instance.go and it can probably only cause confusion. I'd like to propose removing it and doing some more testing if you agree.

I'd also like to say again that GetOkExists is being used by resource_aws_instance.go, right now for this same property. I really think its best to be consistent with that established code and phase out GetOkExists later when there is a replacement. Separately, it would also be helpful if someone could explain exactly why it was deprecated. It seems to me the problem is with GetOk returning a false for ok when in fact the property is present. GetOKExists seems to be a reasonable workaround for that and the deprecation should be aimed at GetOk if anything. Disclaimer: my experience with this code base is a few days.

zhelding · 2021-10-19T16:39:52Z

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

This reverts commit 7ff5cf9.

This reverts commit 86c4ecf.

This reverts commit e3432fe.

…lse." This reverts commit bb190dd.

Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfigurationDataSource_' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfigurationDataSource_ -timeout 180m === RUN TestAccAutoScalingLaunchConfigurationDataSource_basic === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_basic === RUN TestAccAutoScalingLaunchConfigurationDataSource_securityGroups === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_securityGroups === RUN TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice === RUN TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions === CONT TestAccAutoScalingLaunchConfigurationDataSource_basic === CONT TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_basic (46.67s) === CONT TestAccAutoScalingLaunchConfigurationDataSource_securityGroups --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice (49.87s) === CONT TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_securityGroups (49.16s) --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions (46.86s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 103.951s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_basic' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_basic -timeout 180m === RUN TestAccAutoScalingLaunchConfiguration_basic === PAUSE TestAccAutoScalingLaunchConfiguration_basic === CONT TestAccAutoScalingLaunchConfiguration_basic --- PASS: TestAccAutoScalingLaunchConfiguration_basic (55.47s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 62.149s

…ation_withBlockDevices'. Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_withBlockDevices' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_withBlockDevices -timeout 180m === RUN TestAccAutoScalingLaunchConfiguration_withBlockDevices === PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices === CONT TestAccAutoScalingLaunchConfiguration_withBlockDevices --- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (48.77s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 55.546s

…ation_encryptedRootBlockDevice'. Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice -timeout 180m === RUN TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === CONT TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (47.46s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 55.217s

…ation_encryptedEBSBlockDevice'. Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice -timeout 180m === RUN TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === CONT TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice (103.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 111.086s

…ation_userData'. Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_userData' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_userData -timeout 180m === RUN TestAccAutoScalingLaunchConfiguration_userData === PAUSE TestAccAutoScalingLaunchConfiguration_userData === CONT TestAccAutoScalingLaunchConfiguration_userData --- PASS: TestAccAutoScalingLaunchConfiguration_userData (104.54s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 110.236s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_ -timeout 180m === RUN TestAccAutoScalingLaunchConfiguration_basic === PAUSE TestAccAutoScalingLaunchConfiguration_basic === RUN TestAccAutoScalingLaunchConfiguration_disappears === PAUSE TestAccAutoScalingLaunchConfiguration_disappears === RUN TestAccAutoScalingLaunchConfiguration_Name_generated === PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated === RUN TestAccAutoScalingLaunchConfiguration_namePrefix === PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix === RUN TestAccAutoScalingLaunchConfiguration_withBlockDevices === PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices === RUN TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI === PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI === RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears === PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears === RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize === PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize === RUN TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === RUN TestAccAutoScalingLaunchConfiguration_withSpotPrice === PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice === RUN TestAccAutoScalingLaunchConfiguration_withVPCClassicLink === PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink === RUN TestAccAutoScalingLaunchConfiguration_withIAMProfile === PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile === RUN TestAccAutoScalingLaunchConfiguration_withGP3 === PAUSE TestAccAutoScalingLaunchConfiguration_withGP3 === RUN TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === RUN TestAccAutoScalingLaunchConfiguration_metadataOptions === PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions === RUN TestAccAutoScalingLaunchConfiguration_EBS_noDevice === PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice === RUN TestAccAutoScalingLaunchConfiguration_userData === PAUSE TestAccAutoScalingLaunchConfiguration_userData === CONT TestAccAutoScalingLaunchConfiguration_basic === CONT TestAccAutoScalingLaunchConfiguration_withSpotPrice --- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (59.21s) === CONT TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_basic (63.72s) === CONT TestAccAutoScalingLaunchConfiguration_userData --- PASS: TestAccAutoScalingLaunchConfiguration_userData (111.29s) === CONT TestAccAutoScalingLaunchConfiguration_EBS_noDevice --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice (115.90s) === CONT TestAccAutoScalingLaunchConfiguration_metadataOptions --- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (57.50s) === CONT TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI --- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (65.02s) === CONT TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (53.31s) === CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (59.14s) === CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears --- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (97.52s) === CONT TestAccAutoScalingLaunchConfiguration_namePrefix --- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (46.23s) === CONT TestAccAutoScalingLaunchConfiguration_withBlockDevices --- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (48.49s) === CONT TestAccAutoScalingLaunchConfiguration_withIAMProfile --- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (63.53s) === CONT TestAccAutoScalingLaunchConfiguration_withGP3 --- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (54.15s) === CONT TestAccAutoScalingLaunchConfiguration_disappears --- PASS: TestAccAutoScalingLaunchConfiguration_disappears (38.94s) === CONT TestAccAutoScalingLaunchConfiguration_withVPCClassicLink --- PASS: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (51.65s) === CONT TestAccAutoScalingLaunchConfiguration_Name_generated --- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (401.18s) --- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (44.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 737.366s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_ -timeout 180m === RUN TestAccAutoScalingLaunchConfiguration_basic === PAUSE TestAccAutoScalingLaunchConfiguration_basic === RUN TestAccAutoScalingLaunchConfiguration_disappears === PAUSE TestAccAutoScalingLaunchConfiguration_disappears === RUN TestAccAutoScalingLaunchConfiguration_Name_generated === PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated === RUN TestAccAutoScalingLaunchConfiguration_namePrefix === PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix === RUN TestAccAutoScalingLaunchConfiguration_withBlockDevices === PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices === RUN TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI === PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI === RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears === PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears === RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize === PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize === RUN TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === RUN TestAccAutoScalingLaunchConfiguration_withSpotPrice === PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice === RUN TestAccAutoScalingLaunchConfiguration_withVPCClassicLink === PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink === RUN TestAccAutoScalingLaunchConfiguration_withIAMProfile === PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile === RUN TestAccAutoScalingLaunchConfiguration_withGP3 === PAUSE TestAccAutoScalingLaunchConfiguration_withGP3 === RUN TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === RUN TestAccAutoScalingLaunchConfiguration_metadataOptions === PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions === RUN TestAccAutoScalingLaunchConfiguration_EBS_noDevice === PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice === RUN TestAccAutoScalingLaunchConfiguration_userData === PAUSE TestAccAutoScalingLaunchConfiguration_userData === CONT TestAccAutoScalingLaunchConfiguration_basic === CONT TestAccAutoScalingLaunchConfiguration_withSpotPrice === CONT TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_basic (47.77s) --- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (47.86s) === CONT TestAccAutoScalingLaunchConfiguration_userData --- PASS: TestAccAutoScalingLaunchConfiguration_userData (82.51s) === CONT TestAccAutoScalingLaunchConfiguration_EBS_noDevice --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice (86.29s) === CONT TestAccAutoScalingLaunchConfiguration_metadataOptions --- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (46.16s) === CONT TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI --- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (45.48s) === CONT TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (44.60s) === CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (45.40s) === CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears --- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (90.96s) === CONT TestAccAutoScalingLaunchConfiguration_namePrefix --- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (46.44s) === CONT TestAccAutoScalingLaunchConfiguration_withBlockDevices --- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (45.75s) === CONT TestAccAutoScalingLaunchConfiguration_Name_generated --- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (44.41s) === CONT TestAccAutoScalingLaunchConfiguration_disappears --- PASS: TestAccAutoScalingLaunchConfiguration_disappears (42.08s) === CONT TestAccAutoScalingLaunchConfiguration_withIAMProfile --- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (55.06s) === CONT TestAccAutoScalingLaunchConfiguration_withGP3 --- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (42.44s) === CONT TestAccAutoScalingLaunchConfiguration_withVPCClassicLink --- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (399.19s) --- PASS: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (50.86s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 643.648s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration' PKG=autoscaling ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration -timeout 180m === RUN TestAccAutoScalingLaunchConfigurationDataSource_basic === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_basic === RUN TestAccAutoScalingLaunchConfigurationDataSource_securityGroups === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_securityGroups === RUN TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice === RUN TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions === RUN TestAccAutoScalingLaunchConfiguration_basic === PAUSE TestAccAutoScalingLaunchConfiguration_basic === RUN TestAccAutoScalingLaunchConfiguration_disappears === PAUSE TestAccAutoScalingLaunchConfiguration_disappears === RUN TestAccAutoScalingLaunchConfiguration_Name_generated === PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated === RUN TestAccAutoScalingLaunchConfiguration_namePrefix === PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix === RUN TestAccAutoScalingLaunchConfiguration_withBlockDevices === PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices === RUN TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI === PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI === RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears === PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears === RUN TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize === PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize === RUN TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice === RUN TestAccAutoScalingLaunchConfiguration_withSpotPrice === PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice === RUN TestAccAutoScalingLaunchConfiguration_withVPCClassicLink === PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink === RUN TestAccAutoScalingLaunchConfiguration_withIAMProfile === PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile === RUN TestAccAutoScalingLaunchConfiguration_withGP3 === PAUSE TestAccAutoScalingLaunchConfiguration_withGP3 === RUN TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === PAUSE TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice === RUN TestAccAutoScalingLaunchConfiguration_metadataOptions === PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions === RUN TestAccAutoScalingLaunchConfiguration_EBS_noDevice === PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice === RUN TestAccAutoScalingLaunchConfiguration_userData === PAUSE TestAccAutoScalingLaunchConfiguration_userData === CONT TestAccAutoScalingLaunchConfigurationDataSource_basic === CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_basic (43.21s) === CONT TestAccAutoScalingLaunchConfiguration_withGP3 --- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (86.70s) === CONT TestAccAutoScalingLaunchConfiguration_userData --- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (43.80s) === CONT TestAccAutoScalingLaunchConfiguration_EBS_noDevice --- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (44.13s) === CONT TestAccAutoScalingLaunchConfiguration_metadataOptions --- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (42.77s) === CONT TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_userData (94.06s) === CONT TestAccAutoScalingLaunchConfiguration_withVPCClassicLink --- PASS: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (57.78s) === CONT TestAccAutoScalingLaunchConfiguration_withIAMProfile --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice (85.26s) === CONT TestAccAutoScalingLaunchConfiguration_Name_generated --- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (56.34s) === CONT TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears --- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (50.85s) === CONT TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI --- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (43.21s) === CONT TestAccAutoScalingLaunchConfiguration_withBlockDevices --- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (51.26s) === CONT TestAccAutoScalingLaunchConfiguration_namePrefix --- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (45.23s) === CONT TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions (49.73s) === CONT TestAccAutoScalingLaunchConfiguration_disappears --- PASS: TestAccAutoScalingLaunchConfiguration_disappears (41.86s) === CONT TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice (43.80s) === CONT TestAccAutoScalingLaunchConfigurationDataSource_securityGroups --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_securityGroups (47.26s) === CONT TestAccAutoScalingLaunchConfiguration_withSpotPrice --- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (48.29s) === CONT TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice --- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (418.06s) === CONT TestAccAutoScalingLaunchConfiguration_basic --- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (40.75s) --- PASS: TestAccAutoScalingLaunchConfiguration_basic (48.39s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 766.190s

This reverts commit 388a458.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingLaunchConfiguration -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfigurationDataSource_basic
=== PAUSE TestAccAutoScalingLaunchConfigurationDataSource_basic
=== RUN   TestAccAutoScalingLaunchConfigurationDataSource_securityGroups
=== PAUSE TestAccAutoScalingLaunchConfigurationDataSource_securityGroups
=== RUN   TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice
=== PAUSE TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice
=== RUN   TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions
=== PAUSE TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions
=== RUN   TestAccAutoScalingLaunchConfiguration_basic
=== PAUSE TestAccAutoScalingLaunchConfiguration_basic
=== RUN   TestAccAutoScalingLaunchConfiguration_disappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_disappears
=== RUN   TestAccAutoScalingLaunchConfiguration_Name_generated
=== PAUSE TestAccAutoScalingLaunchConfiguration_Name_generated
=== RUN   TestAccAutoScalingLaunchConfiguration_namePrefix
=== PAUSE TestAccAutoScalingLaunchConfiguration_namePrefix
=== RUN   TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAutoScalingLaunchConfiguration_withBlockDevices
=== RUN   TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== PAUSE TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
=== RUN   TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAutoScalingLaunchConfiguration_withSpotPrice
=== RUN   TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== PAUSE TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
=== RUN   TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAutoScalingLaunchConfiguration_withIAMProfile
=== RUN   TestAccAutoScalingLaunchConfiguration_withGP3
=== PAUSE TestAccAutoScalingLaunchConfiguration_withGP3
=== RUN   TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_metadataOptions
=== PAUSE TestAccAutoScalingLaunchConfiguration_metadataOptions
=== RUN   TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== PAUSE TestAccAutoScalingLaunchConfiguration_EBS_noDevice
=== RUN   TestAccAutoScalingLaunchConfiguration_userData
=== PAUSE TestAccAutoScalingLaunchConfiguration_userData
=== CONT  TestAccAutoScalingLaunchConfigurationDataSource_basic
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize
--- PASS: TestAccAutoScalingLaunchConfigurationDataSource_basic (43.21s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withGP3
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_volumeSize (86.70s)
=== CONT  TestAccAutoScalingLaunchConfiguration_userData
--- PASS: TestAccAutoScalingLaunchConfiguration_withGP3 (43.80s)
=== CONT  TestAccAutoScalingLaunchConfiguration_EBS_noDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_EBS_noDevice (44.13s)
=== CONT  TestAccAutoScalingLaunchConfiguration_metadataOptions
--- PASS: TestAccAutoScalingLaunchConfiguration_metadataOptions (42.77s)
=== CONT  TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_userData (94.06s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withVPCClassicLink
--- PASS: TestAccAutoScalingLaunchConfiguration_withVPCClassicLink (57.78s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withIAMProfile
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedEBSBlockDevice (85.26s)
=== CONT  TestAccAutoScalingLaunchConfiguration_Name_generated
--- PASS: TestAccAutoScalingLaunchConfiguration_withIAMProfile (56.34s)
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
--- PASS: TestAccAutoScalingLaunchConfiguration_Name_generated (50.85s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI
--- PASS: TestAccAutoScalingLaunchConfiguration_withInstanceStoreAMI (43.21s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withBlockDevices
--- PASS: TestAccAutoScalingLaunchConfiguration_withBlockDevices (51.26s)
=== CONT  TestAccAutoScalingLaunchConfiguration_namePrefix
--- PASS: TestAccAutoScalingLaunchConfiguration_namePrefix (45.23s)
=== CONT  TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions
--- PASS: TestAccAutoScalingLaunchConfigurationDataSource_metadataOptions (49.73s)
=== CONT  TestAccAutoScalingLaunchConfiguration_disappears
--- PASS: TestAccAutoScalingLaunchConfiguration_disappears (41.86s)
=== CONT  TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice
--- PASS: TestAccAutoScalingLaunchConfigurationDataSource_ebsNoDevice (43.80s)
=== CONT  TestAccAutoScalingLaunchConfigurationDataSource_securityGroups
--- PASS: TestAccAutoScalingLaunchConfigurationDataSource_securityGroups (47.26s)
=== CONT  TestAccAutoScalingLaunchConfiguration_withSpotPrice
--- PASS: TestAccAutoScalingLaunchConfiguration_withSpotPrice (48.29s)
=== CONT  TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (418.06s)
=== CONT  TestAccAutoScalingLaunchConfiguration_basic
--- PASS: TestAccAutoScalingLaunchConfiguration_encryptedRootBlockDevice (40.75s)
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (48.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	766.190s

ewbankkit · 2022-05-31T22:14:42Z

% semgrep -c .semgrep-service-name0.yml            
Scanning 3942 files with 107 go rules.
  100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████|3942/3942 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1593 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 107 rules on 3942 files: 0 findings.
% make providerlint && make golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

ewbankkit · 2022-05-31T22:32:49Z

@rick-masters Thanks for the contribution 🎉 👏.

github-actions · 2022-06-03T11:56:33Z

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

dghubble · 2022-06-08T22:20:09Z

unfortunately it leads to the opposite problem - an explicit "false" will be provided when instead the instance should pick up the default from the subnet. So the instance does not get a public IP.

@ewbankkit this is a regression

github-actions · 2022-07-09T02:32:14Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

MarcusNoble and others added 4 commits April 18, 2019 04:57

Added tests for on demand capacity bug

86c4ecf

Remove diff suppression func

7ff5cf9

Launch Template support for Autoscaling Group data source

e3432fe

Use getOkExists to retrieve associate_public_ip_address as false.

bb190dd

rick-masters requested a review from a team as a code owner February 19, 2021 01:06

ghost added size/XS Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Feb 19, 2021

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 19, 2021

Update CHANGELOG.md for hashicorp#17695

9a44833

DrFaust92 suggested changes Feb 19, 2021

View reviewed changes

aws/resource_aws_launch_configuration.go Outdated Show resolved Hide resolved

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2021

ewbankkit added 7 commits May 27, 2022 11:47

Revert "Remove diff suppression func"

d981508

This reverts commit 7ff5cf9.

Revert "Added tests for on demand capacity bug"

afa0034

This reverts commit 86c4ecf.

Revert "Launch Template support for Autoscaling Group data source"

fc04049

This reverts commit e3432fe.

Merge commit 'afa00344db05968d7c44637003198f666c99eb81' into HEAD

57b0b91

Merge branch 'main' into HEAD

cc0fff0

Revert "Use getOkExists to retrieve associate_public_ip_address as fa…

c873a6d

…lse." This reverts commit bb190dd.

Merge commit 'cc0fff0ee90634c6bb137ec44732684543b68dbe' into HEAD

bd53eac

ewbankkit added bug Addresses a defect in current functionality. and removed enhancement Requests to existing resources that expand the functionality or scope. labels May 27, 2022

ewbankkit self-assigned this May 27, 2022

ewbankkit added 6 commits May 27, 2022 13:52

r/aws_laucnh_configuration: Tidy up resource Read.

9cf8ba9

d/aws_autoscaling_launch_configuration: Alphabetize attributes.

17cad18

ewbankkit and others added 7 commits May 27, 2022 15:54

Initial Commit

388a458

r/aws_ami: Handle unavailable AMI error on resource Delete.

e8470d1

ewbankkit added 4 commits May 31, 2022 17:40

Revert "Initial Commit"

d608a7c

This reverts commit 388a458.

Merge commit 'd608a7c1e00497b2c816a80ff2e53d009dc44ca2' into HEAD

6d84364

d/aws_launch_configuration: Correct data type for 'throughput'.

056bf0b

Fix terrafmt errors.

7087836

ewbankkit approved these changes May 31, 2022

View reviewed changes

ewbankkit mentioned this pull request May 31, 2022

Initial Commit #25097

Closed

Fix Semgrep naming errors.

ac3f2c3

ewbankkit merged commit 9f6fa8e into hashicorp:main May 31, 2022

github-actions bot added this to the v4.17.0 milestone May 31, 2022

dghubble mentioned this pull request Jun 8, 2022

aws_launch_configuraiton defaults to disabling IPv4 auto-assignment, ignoring subnet settings #25244

Closed

MatthewFagan mentioned this pull request Jun 14, 2022

4.17.0 broke public subnets in eks #25252

Closed

This was referenced Jun 17, 2022

Contributor Documentation Refactor #25304

Merged

r/aws_launch_configuration: No default for associate_public_ip_address #25450

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use getOkExists to retrieve associate_public_ip_address as false. #17695

Use getOkExists to retrieve associate_public_ip_address as false. #17695

rick-masters commented Feb 19, 2021 •

edited by ewbankkit

Loading

rick-masters commented Feb 19, 2021

zhelding commented Oct 19, 2021

ewbankkit left a comment

ewbankkit commented May 31, 2022

ewbankkit commented May 31, 2022

github-actions bot commented Jun 3, 2022

dghubble commented Jun 8, 2022

github-actions bot commented Jul 9, 2022

Use getOkExists to retrieve associate_public_ip_address as false. #17695

Use getOkExists to retrieve associate_public_ip_address as false. #17695

Conversation

rick-masters commented Feb 19, 2021 • edited by ewbankkit Loading

Community Note

rick-masters commented Feb 19, 2021

zhelding commented Oct 19, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented May 31, 2022

ewbankkit commented May 31, 2022

github-actions bot commented Jun 3, 2022

dghubble commented Jun 8, 2022

github-actions bot commented Jul 9, 2022

rick-masters commented Feb 19, 2021 •

edited by ewbankkit

Loading