r/synthetics_canary - fix canary update

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17642

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSyntheticsCanary_'
--- PASS: TestAccAWSSyntheticsCanary_disappears (102.15s)
--- PASS: TestAccAWSSyntheticsCanary_s3 (114.20s)
--- PASS: TestAccAWSSyntheticsCanary_basic (164.13s)
--- PASS: TestAccAWSSyntheticsCanary_runtimeVersion (172.09s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary_codeChanges (175.97s)
--- PASS: TestAccAWSSyntheticsCanary_tags (206.14s)
--- PASS: TestAccAWSSyntheticsCanary_runConfig (211.43s)
--- PASS: TestAccAWSSyntheticsCanary_runConfigTracing (217.31s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary (228.48s)
--- PASS: TestAccAWSSyntheticsCanary_vpc (778.07s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSyntheticsCanary_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSSyntheticsCanary_ -timeout 120m
=== RUN   TestAccAWSSyntheticsCanary_basic
=== PAUSE TestAccAWSSyntheticsCanary_basic
=== RUN   TestAccAWSSyntheticsCanary_runtimeVersion
=== PAUSE TestAccAWSSyntheticsCanary_runtimeVersion
=== RUN   TestAccAWSSyntheticsCanary_startCanary
=== PAUSE TestAccAWSSyntheticsCanary_startCanary
=== RUN   TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== PAUSE TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== RUN   TestAccAWSSyntheticsCanary_s3
=== PAUSE TestAccAWSSyntheticsCanary_s3
=== RUN   TestAccAWSSyntheticsCanary_runConfig
=== PAUSE TestAccAWSSyntheticsCanary_runConfig
=== RUN   TestAccAWSSyntheticsCanary_runConfigTracing
=== PAUSE TestAccAWSSyntheticsCanary_runConfigTracing
=== RUN   TestAccAWSSyntheticsCanary_vpc
=== PAUSE TestAccAWSSyntheticsCanary_vpc
=== RUN   TestAccAWSSyntheticsCanary_tags
=== PAUSE TestAccAWSSyntheticsCanary_tags
=== RUN   TestAccAWSSyntheticsCanary_disappears
=== PAUSE TestAccAWSSyntheticsCanary_disappears
=== CONT  TestAccAWSSyntheticsCanary_basic
=== CONT  TestAccAWSSyntheticsCanary_disappears
--- PASS: TestAccAWSSyntheticsCanary_disappears (44.09s)
=== CONT  TestAccAWSSyntheticsCanary_tags
--- PASS: TestAccAWSSyntheticsCanary_basic (94.56s)
=== CONT  TestAccAWSSyntheticsCanary_vpc
--- PASS: TestAccAWSSyntheticsCanary_tags (87.27s)
=== CONT  TestAccAWSSyntheticsCanary_runConfigTracing
=== CONT  TestAccAWSSyntheticsCanary_runConfig
--- PASS: TestAccAWSSyntheticsCanary_runConfigTracing (87.67s)
--- PASS: TestAccAWSSyntheticsCanary_runConfig (89.22s)
=== CONT  TestAccAWSSyntheticsCanary_s3
--- PASS: TestAccAWSSyntheticsCanary_s3 (59.08s)
=== CONT  TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== CONT  TestAccAWSSyntheticsCanary_startCanary
--- PASS: TestAccAWSSyntheticsCanary_startCanary_codeChanges (86.36s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary (91.85s)
=== CONT  TestAccAWSSyntheticsCanary_runtimeVersion
--- PASS: TestAccAWSSyntheticsCanary_runtimeVersion (81.95s)
--- PASS: TestAccAWSSyntheticsCanary_vpc (666.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	761.131s

[bflad]

One minor thing, otherwise looks great, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSyntheticsCanary_disappears (59.10s)
--- PASS: TestAccAWSSyntheticsCanary_s3 (65.68s)
--- PASS: TestAccAWSSyntheticsCanary_basic (92.10s)
--- PASS: TestAccAWSSyntheticsCanary_runConfigTracing (93.37s)
--- PASS: TestAccAWSSyntheticsCanary_runConfig (93.68s)
--- PASS: TestAccAWSSyntheticsCanary_tags (95.60s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary_codeChanges (104.92s)
--- PASS: TestAccAWSSyntheticsCanary_runtimeVersion (105.96s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary (117.58s)
--- PASS: TestAccAWSSyntheticsCanary_vpc (693.51s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSyntheticsCanary_disappears (63.23s)
--- PASS: TestAccAWSSyntheticsCanary_s3 (67.62s)
--- PASS: TestAccAWSSyntheticsCanary_basic (84.47s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary_codeChanges (85.49s)
--- PASS: TestAccAWSSyntheticsCanary_runtimeVersion (111.19s)
--- PASS: TestAccAWSSyntheticsCanary_tags (111.24s)
--- PASS: TestAccAWSSyntheticsCanary_runConfigTracing (112.80s)
--- PASS: TestAccAWSSyntheticsCanary_runConfig (112.90s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary (114.62s)
--- PASS: TestAccAWSSyntheticsCanary_vpc (1954.15s)

[ghost]

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!