Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/codedeploy_app - add arn attribute & tagging support & sweeper #18564

Merged
merged 10 commits into from
Apr 14, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 4, 2021

Relates #8774

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeDeployApp_'
--- PASS: TestAccAWSCodeDeployApp_disappears (29.33s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform_Lambda (38.70s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform_ECS (39.01s)
--- PASS: TestAccAWSCodeDeployApp_basic (44.33s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform (61.79s)
--- PASS: TestAccAWSCodeDeployApp_name (64.22s)
--- PASS: TestAccAWSCodeDeployApp_tags (93.42s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner April 4, 2021 22:22
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/codedeploy tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 4, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 4, 2021
@DrFaust92 DrFaust92 changed the title r/codedeploy_app - add arn attribute & tagging support r/codedeploy_app - add arn attribute & tagging support & sweeper Apr 8, 2021
@anGie44 anGie44 self-assigned this Apr 14, 2021
DrFaust92 and others added 4 commits April 14, 2021 20:13
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Apr 14, 2021
@DrFaust92
Copy link
Collaborator Author

Thanks @anGie44 addressed changes

--- PASS: TestAccAWSCodeDeployApp_disappears (27.04s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform_Lambda (37.48s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform_ECS (37.80s)
--- PASS: TestAccAWSCodeDeployApp_basic (44.69s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform (59.50s)
--- PASS: TestAccAWSCodeDeployApp_name (63.87s)
--- PASS: TestAccAWSCodeDeployApp_tags (90.22s)

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrFaust92 , looks great 👍

Output of acceptance tests (commercial):

--- PASS: TestAccAWSCodeDeployApp_disappears (18.63s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform_Lambda (23.43s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform_ECS (25.15s)
--- PASS: TestAccAWSCodeDeployApp_basic (27.11s)
--- PASS: TestAccAWSCodeDeployApp_computePlatform (33.01s)
--- PASS: TestAccAWSCodeDeployApp_name (34.09s)
--- PASS: TestAccAWSCodeDeployApp_tags (44.21s)

Sweeper output:

go test ./aws -v -sweep=us-east-1,us-west-2 -sweep-run=aws_codedeploy_app -timeout 60m
2021/04/14 16:14:45 [DEBUG] Running Sweepers for region (us-east-1):
2021/04/14 16:14:45 [DEBUG] Running Sweeper (aws_codedeploy_app) in region (us-east-1)
2021/04/14 16:14:45 [INFO] AWS Auth provider used: "EnvProvider"
2021/04/14 16:14:45 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/04/14 16:14:45 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/04/14 16:14:46 Sweeper Tests ran successfully:
	- aws_codedeploy_app
2021/04/14 16:14:46 [DEBUG] Running Sweepers for region (us-west-2):
2021/04/14 16:14:46 [DEBUG] Running Sweeper (aws_codedeploy_app) in region (us-west-2)
2021/04/14 16:14:46 [INFO] AWS Auth provider used: "EnvProvider"
2021/04/14 16:14:46 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/04/14 16:14:46 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/04/14 16:14:47 Sweeper Tests ran successfully:
	- aws_codedeploy_app

@anGie44 anGie44 added this to the v3.37.0 milestone Apr 14, 2021
@anGie44 anGie44 merged commit 511c1d7 into hashicorp:main Apr 14, 2021
@DrFaust92 DrFaust92 deleted the r/codedeploy_app_arn_tags branch April 15, 2021 10:34
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants