Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for taints on EKS Managed NodeGroup (aws_eks_node_group) #19310

Closed
petewilcock opened this issue May 11, 2021 · 6 comments · Fixed by #19482
Closed

Support for taints on EKS Managed NodeGroup (aws_eks_node_group) #19310

petewilcock opened this issue May 11, 2021 · 6 comments · Fixed by #19482
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@petewilcock
Copy link

petewilcock commented May 11, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Previously requested in 12780 but closed as no coverage in the API. As of 11/05/21 this is now supported. Changelog.

New or Affected Resource(s)

  • aws_eks_node_group

Potential Terraform Configuration

taints resource block that can be specified 0 to n times:

taints {
    key = "Name of taint"
    value = "Value of taint"
    effect = "NO_SCHEDULE"|"NO_EXECUTE"|"PREFER_NO_SCHEDULE"
}

References

@petewilcock petewilcock added the enhancement Requests to existing resources that expand the functionality or scope. label May 11, 2021
@ghost ghost added the service/eks Issues and PRs that pertain to the eks service. label May 11, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 11, 2021
@alessio4tech
Copy link

Hi @petewilcock,

I'm interested in this feature and I would like to spend some time working on this enhancement. Could you please assign this to me ?

@petewilcock
Copy link
Author

Hi @petewilcock,

I'm interested in this feature and I would like to spend some time working on this enhancement. Could you please assign this to me ?

I don't have the power to assign but check out the Contributor Guide for process :)

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 11, 2021
@ewbankkit
Copy link
Contributor

Requires AWS SDK v1.38.37:

@ewbankkit
Copy link
Contributor

Announcement.
User Guide.

@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants