Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cloudwatch_log_metric_filter: support dimensions #19608

Closed
roberth-k opened this issue Jun 1, 2021 · 3 comments · Fixed by #19625
Closed

resource/aws_cloudwatch_log_metric_filter: support dimensions #19608

roberth-k opened this issue Jun 1, 2021 · 3 comments · Fixed by #19625
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Milestone

Comments

@roberth-k
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

CloudWatch Logs Metric Filters now support up to 3 dimensions, which are specified in pattern format. It's a new field of metric_transformation.

Metric Filters with dimensions don't allow the default value to be set.

AWS's documentation leaves this unclear, but it's worth testing whether constant values are also supported by this feature.

Requires Go SDK v1.38.46 (released on 2021-05-24).

New or Affected Resource(s)

  • aws_cloudwatch_log_metric_filter

Potential Terraform Configuration

resource "aws_cloudwatch_log_metric_filter" "example" {
  name           = "Example"
  pattern        = ""
  log_group_name = aws_cloudwatch_log_group.example.name

  metric_transformation {
    name       = "EventCount"
    namespace  = "Example"
    value      = "1"
    dimensions = {
      // the value is a metric filter pattern
      EventType = "$.eventType"
    }
  }
}

References

@roberth-k roberth-k added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 1, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/cloudwatchlogs labels Jun 1, 2021
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 1, 2021
@roberth-k
Copy link
Contributor Author

Implemented in: #19625

@ewbankkit ewbankkit removed the new-resource Introduces a new resource. label Jun 2, 2021
@github-actions github-actions bot added this to the v3.44.0 milestone Jun 2, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants