r/aws_sqs_queue: Backwards compatibility fix for default kms_data_key_reuse_period_seconds

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19786.

Output from acceptance testing:

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_\|TestAccAWSSQSQueuePolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSQSQueue_\|TestAccAWSSQSQueuePolicy_ -timeout 180m
=== RUN   TestAccAWSSQSQueuePolicy_basic
=== PAUSE TestAccAWSSQSQueuePolicy_basic
=== RUN   TestAccAWSSQSQueuePolicy_disappears
=== PAUSE TestAccAWSSQSQueuePolicy_disappears
=== RUN   TestAccAWSSQSQueuePolicy_disappears_queue
=== PAUSE TestAccAWSSQSQueuePolicy_disappears_queue
=== RUN   TestAccAWSSQSQueuePolicy_Update
=== PAUSE TestAccAWSSQSQueuePolicy_Update
=== RUN   TestAccAWSSQSQueue_basic
=== PAUSE TestAccAWSSQSQueue_basic
=== RUN   TestAccAWSSQSQueue_disappears
=== PAUSE TestAccAWSSQSQueue_disappears
=== RUN   TestAccAWSSQSQueue_Name_Generated
=== PAUSE TestAccAWSSQSQueue_Name_Generated
=== RUN   TestAccAWSSQSQueue_Name_Generated_FIFOQueue
=== PAUSE TestAccAWSSQSQueue_Name_Generated_FIFOQueue
=== RUN   TestAccAWSSQSQueue_NamePrefix
=== PAUSE TestAccAWSSQSQueue_NamePrefix
=== RUN   TestAccAWSSQSQueue_NamePrefix_FIFOQueue
=== PAUSE TestAccAWSSQSQueue_NamePrefix_FIFOQueue
=== RUN   TestAccAWSSQSQueue_Tags
=== PAUSE TestAccAWSSQSQueue_Tags
=== RUN   TestAccAWSSQSQueue_Update
=== PAUSE TestAccAWSSQSQueue_Update
=== RUN   TestAccAWSSQSQueue_Policy
=== PAUSE TestAccAWSSQSQueue_Policy
=== RUN   TestAccAWSSQSQueue_RecentlyDeleted
=== PAUSE TestAccAWSSQSQueue_RecentlyDeleted
=== RUN   TestAccAWSSQSQueue_RedrivePolicy
=== PAUSE TestAccAWSSQSQueue_RedrivePolicy
=== RUN   TestAccAWSSQSQueue_FIFOQueue
=== PAUSE TestAccAWSSQSQueue_FIFOQueue
=== RUN   TestAccAWSSQSQueue_FIFOQueue_ExpectNameError
=== PAUSE TestAccAWSSQSQueue_FIFOQueue_ExpectNameError
=== RUN   TestAccAWSSQSQueue_FIFOQueue_ContentBasedDeduplication
=== PAUSE TestAccAWSSQSQueue_FIFOQueue_ContentBasedDeduplication
=== RUN   TestAccAWSSQSQueue_FIFOQueue_HighThroughputMode
=== PAUSE TestAccAWSSQSQueue_FIFOQueue_HighThroughputMode
=== RUN   TestAccAWSSQSQueue_StandardQueue_ExpectContentBasedDeduplicationError
=== PAUSE TestAccAWSSQSQueue_StandardQueue_ExpectContentBasedDeduplicationError
=== RUN   TestAccAWSSQSQueue_Encryption
=== PAUSE TestAccAWSSQSQueue_Encryption
=== RUN   TestAccAWSSQSQueue_ZeroVisibilityTimeoutSeconds
=== PAUSE TestAccAWSSQSQueue_ZeroVisibilityTimeoutSeconds
=== RUN   TestAccAWSSQSQueue_DefaultKmsDataKeyReusePeriodSeconds
=== PAUSE TestAccAWSSQSQueue_DefaultKmsDataKeyReusePeriodSeconds
=== CONT  TestAccAWSSQSQueuePolicy_basic
=== CONT  TestAccAWSSQSQueue_Policy
=== CONT  TestAccAWSSQSQueuePolicy_Update
=== CONT  TestAccAWSSQSQueuePolicy_disappears
=== CONT  TestAccAWSSQSQueue_ZeroVisibilityTimeoutSeconds
=== CONT  TestAccAWSSQSQueue_Update
=== CONT  TestAccAWSSQSQueue_Tags
=== CONT  TestAccAWSSQSQueue_NamePrefix_FIFOQueue
=== CONT  TestAccAWSSQSQueue_NamePrefix
=== CONT  TestAccAWSSQSQueue_Name_Generated_FIFOQueue
=== CONT  TestAccAWSSQSQueue_Name_Generated
=== CONT  TestAccAWSSQSQueue_FIFOQueue_ContentBasedDeduplication
=== CONT  TestAccAWSSQSQueue_FIFOQueue_ExpectNameError
=== CONT  TestAccAWSSQSQueue_FIFOQueue
=== CONT  TestAccAWSSQSQueue_RedrivePolicy
=== CONT  TestAccAWSSQSQueue_DefaultKmsDataKeyReusePeriodSeconds
=== CONT  TestAccAWSSQSQueue_RecentlyDeleted
=== CONT  TestAccAWSSQSQueue_Encryption
=== CONT  TestAccAWSSQSQueue_FIFOQueue_HighThroughputMode
=== CONT  TestAccAWSSQSQueuePolicy_disappears_queue
--- PASS: TestAccAWSSQSQueue_FIFOQueue_ExpectNameError (9.71s)
=== CONT  TestAccAWSSQSQueue_disappears
--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (34.12s)
=== CONT  TestAccAWSSQSQueue_StandardQueue_ExpectContentBasedDeduplicationError
--- PASS: TestAccAWSSQSQueue_disappears (25.09s)
=== CONT  TestAccAWSSQSQueue_basic
--- PASS: TestAccAWSSQSQueue_Name_Generated (46.92s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (47.01s)
--- PASS: TestAccAWSSQSQueue_ZeroVisibilityTimeoutSeconds (47.64s)
--- PASS: TestAccAWSSQSQueue_StandardQueue_ExpectContentBasedDeduplicationError (14.04s)
--- PASS: TestAccAWSSQSQueue_NamePrefix_FIFOQueue (48.21s)
--- PASS: TestAccAWSSQSQueue_NamePrefix (48.23s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue_ContentBasedDeduplication (48.24s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue (49.21s)
--- PASS: TestAccAWSSQSQueue_DefaultKmsDataKeyReusePeriodSeconds (49.32s)
--- PASS: TestAccAWSSQSQueue_Name_Generated_FIFOQueue (49.80s)
--- PASS: TestAccAWSSQSQueue_RedrivePolicy (53.27s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (64.38s)
--- PASS: TestAccAWSSQSQueue_Encryption (68.37s)
--- PASS: TestAccAWSSQSQueue_Update (68.42s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue_HighThroughputMode (68.52s)
--- PASS: TestAccAWSSQSQueuePolicy_Update (69.42s)
--- PASS: TestAccAWSSQSQueue_basic (35.49s)
--- PASS: TestAccAWSSQSQueue_Policy (79.84s)
--- PASS: TestAccAWSSQSQueue_Tags (83.20s)
--- PASS: TestAccAWSSQSQueue_RecentlyDeleted (93.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	97.153s

[YakDriver]

Commercial looks good! 🎉

GovCloud is a hot mess. Will you create an issue to track it (if one doesn't exist)?

Commercial:

--- PASS: TestAccAWSSQSQueue_FIFOQueue_ExpectNameError (5.77s)
--- PASS: TestAccAWSSQSQueue_disappears (25.44s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (29.38s)
--- PASS: TestAccAWSSQSQueue_StandardQueue_ExpectContentBasedDeduplicationError (5.03s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (31.69s)
--- PASS: TestAccAWSSQSQueue_Name_Generated_FIFOQueue (31.77s)
--- PASS: TestAccAWSSQSQueue_NamePrefix_FIFOQueue (36.07s)
--- PASS: TestAccAWSSQSQueue_NamePrefix (36.11s)
--- PASS: TestAccAWSSQSQueue_ZeroVisibilityTimeoutSeconds (30.35s)
--- PASS: TestAccAWSSQSQueue_basic (36.18s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue_ContentBasedDeduplication (36.21s)
--- PASS: TestAccAWSSQSQueue_DefaultKmsDataKeyReusePeriodSeconds (36.30s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue (36.30s)
--- PASS: TestAccAWSSQSQueue_Name_Generated (36.38s)
--- PASS: TestAccAWSSQSQueue_RedrivePolicy (38.22s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (45.45s)
--- PASS: TestAccAWSSQSQueue_Encryption (50.26s)
--- PASS: TestAccAWSSQSQueue_Update (51.07s)
--- PASS: TestAccAWSSQSQueuePolicy_Update (51.52s)
--- PASS: TestAccAWSSQSQueue_Tags (62.50s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue_HighThroughputMode (36.91s)
--- PASS: TestAccAWSSQSQueue_Policy (74.38s)
--- PASS: TestAccAWSSQSQueue_RecentlyDeleted (91.95s)

GovCloud:

--- FAIL: TestAccAWSSQSQueue_DefaultKmsDataKeyReusePeriodSeconds (39.19s)
--- FAIL: TestAccAWSSQSQueue_Encryption (37.13s)
--- FAIL: TestAccAWSSQSQueue_FIFOQueue_HighThroughputMode (44.94s)
--- FAIL: TestAccAWSSQSQueue_NamePrefix_FIFOQueue (38.51s)
--- FAIL: TestAccAWSSQSQueue_Update (56.62s)
--- FAIL: TestAccAWSSQSQueuePolicy_basic (23.10s)
--- FAIL: TestAccAWSSQSQueuePolicy_Update (23.12s)
--- PASS: TestAccAWSSQSQueue_basic (38.51s)
--- PASS: TestAccAWSSQSQueue_disappears (28.68s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue (38.36s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue_ContentBasedDeduplication (42.63s)
--- PASS: TestAccAWSSQSQueue_FIFOQueue_ExpectNameError (8.15s)
--- PASS: TestAccAWSSQSQueue_Name_Generated (43.84s)
--- PASS: TestAccAWSSQSQueue_Name_Generated_FIFOQueue (46.56s)
--- PASS: TestAccAWSSQSQueue_NamePrefix (42.90s)
--- PASS: TestAccAWSSQSQueue_Policy (85.03s)
--- PASS: TestAccAWSSQSQueue_RecentlyDeleted (89.37s)
--- PASS: TestAccAWSSQSQueue_RedrivePolicy (40.41s)
--- PASS: TestAccAWSSQSQueue_StandardQueue_ExpectContentBasedDeduplicationError (4.30s)
--- PASS: TestAccAWSSQSQueue_Tags (76.15s)
--- PASS: TestAccAWSSQSQueue_ZeroVisibilityTimeoutSeconds (39.83s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (36.10s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (31.77s)

[ewbankkit]

Will do.
They all seem to be eventual consistency errors and a lot of work was done to ensure that the provider waits for the queue to reach the correct configuration, and then on GovCloud a subsequent API call returns an inconsistent view 😢.

[github-actions]

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.