resource/aws_guardduty_detector: add support for datasources and s3_logs

[farhanangullia]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14607

Release note for CHANGELOG:

enhancement:

resource/aws_guardduty_detector: Add support for `datasources`, `s3_logs` and `enable` arguments

Affected Resource(s)

• resource: aws_guardduty_detector

Terraform Configuration

resource "aws_guardduty_detector" "foo" {
  enable = true

  datasources {
    s3_logs {
      enable = true
    }
  }
}

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGuardDuty_serial/Detector'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGuardDuty_serial/Detector -timeout 180m
=== RUN   TestAccAWSGuardDuty_serial
=== RUN   TestAccAWSGuardDuty_serial/Detector
=== RUN   TestAccAWSGuardDuty_serial/Detector/datasources_s3logs
=== RUN   TestAccAWSGuardDuty_serial/Detector/tags
=== RUN   TestAccAWSGuardDuty_serial/Detector/datasource_basic
=== RUN   TestAccAWSGuardDuty_serial/Detector/datasource_id
=== RUN   TestAccAWSGuardDuty_serial/Detector/basic
--- PASS: TestAccAWSGuardDuty_serial (598.48s)
    --- PASS: TestAccAWSGuardDuty_serial/Detector (598.48s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/datasources_s3logs (110.09s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/tags (146.95s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/datasource_basic (103.87s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/datasource_id (56.30s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/basic (181.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       599.752s

...

[ewbankkit]

LGTM 🚀.

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSGuardDuty_serial/Detector'                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGuardDuty_serial/Detector -timeout 180m
=== RUN   TestAccAWSGuardDuty_serial
=== RUN   TestAccAWSGuardDuty_serial/Detector
=== RUN   TestAccAWSGuardDuty_serial/Detector/basic
=== RUN   TestAccAWSGuardDuty_serial/Detector/datasources_s3logs
=== RUN   TestAccAWSGuardDuty_serial/Detector/tags
=== RUN   TestAccAWSGuardDuty_serial/Detector/datasource_basic
=== RUN   TestAccAWSGuardDuty_serial/Detector/datasource_id
--- PASS: TestAccAWSGuardDuty_serial (163.23s)
    --- PASS: TestAccAWSGuardDuty_serial/Detector (163.23s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/basic (56.25s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/datasources_s3logs (27.60s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/tags (39.06s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/datasource_basic (25.15s)
        --- PASS: TestAccAWSGuardDuty_serial/Detector/datasource_id (15.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	166.269s

[ewbankkit]

@farhanangullia Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.