String validation error text doesn't match regex

[chrismarget]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform 1.0.1
AWS provider 3.49.0

Affected Resource(s)

aws_imagebuilder_distribution_configuration

Debug Output

When specifying that the imagebuilder distribution config apply a name containing a period to the new AMI, the following error is displayed:

Error: invalid value for distribution.1.ami_distribution_configuration.0.name (must contain only alphanumeric characters, periods, underscores, and hyphens)

Panic Output

n/a

Expected Behavior

The validation regex is correct in that periods do not seem to be permitted by AWS, so the error message should not suggest that periods are permitted in this field.

Actual Behavior

The error text indicates that periods are allowed. They are not permitted by the validation regex, nor apparently, by the AWS API.

Steps to Reproduce

Review the regex here:

terraform-provider-aws/aws/resource_aws_imagebuilder_distribution_configuration.go

Line 97 in bae3b38

validation.StringMatch(regexp.MustCompile(`^[-_A-Za-z0-9{][-_A-Za-z0-9\s:{}]+[-_A-Za-z0-9}]$`), "must contain only alphanumeric characters, periods, underscores, and hyphens"),

Important Factoids

Note that the regex suggested by the AWS documentation link above (^[-_A-Za-z-0-9][-_A-Za-z0-9 ]{1,126}[-_A-Za-z-0-9]$) doesn't seem to be correct because it wouldn't allow inclusion of AWS-side substitutions like {{ imagebuilder:buildDate }}

References

AWS API guide

Error text which needs "periods" removed

[kamilturek]

I am going to work on this issue.

[github-actions]

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.