Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle only national character set #20437

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Oracle only national character set #20437

merged 5 commits into from
Aug 4, 2021

Conversation

fergoid
Copy link
Contributor

@fergoid fergoid commented Aug 4, 2021

This adds the option to set the national_character_set variable for Oracle & two new acceptance tests for the Oracle National Character Set parameter. I also fixed up the other Oracle acceptance test as it was referring to an SE version that is no longer supported in RDS; TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle

https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20413

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBInstance_NationalCharacterSet_Oracle'                                          <aws:default>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_NationalCharacterSet_Oracle -timeout 180m
=== RUN   TestAccAWSDBInstance_NationalCharacterSet_Oracle
=== PAUSE TestAccAWSDBInstance_NationalCharacterSet_Oracle
=== CONT  TestAccAWSDBInstance_NationalCharacterSet_Oracle
--- PASS: TestAccAWSDBInstance_NationalCharacterSet_Oracle (1200.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1207.816s

$ make testacc TESTARGS='-run=TestAccAWSDBInstance_NoNationalCharacterSet_Oracle'                                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_NoNationalCharacterSet_Oracle -timeout 180m
=== RUN   TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== PAUSE TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== CONT  TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
--- PASS: TestAccAWSDBInstance_NoNationalCharacterSet_Oracle (1112.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1120.786s

$ make testacc TESTARGS='-run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle'                                  <aws:default>
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle -timeout 180m
=== RUN   TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
=== PAUSE TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
=== CONT  TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (1234.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1243.273s
...

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Aug 4, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @fergoid 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit
Copy link
Contributor

@fergoid Thanks for the contribution 🎉 👏.
To match the underlying AWS RDS API I have changed the name of the new argument to nchar_character_set_name.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 4, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSDBInstance_NoNationalCharacterSet_Oracle\|TestAccAWSDBInstance_NationalCharacterSet_Oracle\|TestAccAWSDBInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_NoNationalCharacterSet_Oracle\|TestAccAWSDBInstance_NationalCharacterSet_Oracle\|TestAccAWSDBInstance_basic -timeout 180m
=== RUN   TestAccAWSDBInstance_basic
=== PAUSE TestAccAWSDBInstance_basic
=== RUN   TestAccAWSDBInstance_NationalCharacterSet_Oracle
=== PAUSE TestAccAWSDBInstance_NationalCharacterSet_Oracle
=== RUN   TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== PAUSE TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== CONT  TestAccAWSDBInstance_basic
=== CONT  TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== CONT  TestAccAWSDBInstance_NationalCharacterSet_Oracle
--- PASS: TestAccAWSDBInstance_basic (448.54s)
--- PASS: TestAccAWSDBInstance_NationalCharacterSet_Oracle (852.30s)
--- PASS: TestAccAWSDBInstance_NoNationalCharacterSet_Oracle (873.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	876.694s
% make testacc TESTARGS='-run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle'                                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle -timeout 180m
=== RUN   TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
=== PAUSE TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
=== CONT  TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (995.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	998.719s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSDBInstance_NoNationalCharacterSet_Oracle\|TestAccAWSDBInstance_NationalCharacterSet_Oracle\|TestAccAWSDBInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_NoNationalCharacterSet_Oracle\|TestAccAWSDBInstance_NationalCharacterSet_Oracle\|TestAccAWSDBInstance_basic -timeout 180m
=== RUN   TestAccAWSDBInstance_basic
=== PAUSE TestAccAWSDBInstance_basic
=== RUN   TestAccAWSDBInstance_NationalCharacterSet_Oracle
=== PAUSE TestAccAWSDBInstance_NationalCharacterSet_Oracle
=== RUN   TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== PAUSE TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== CONT  TestAccAWSDBInstance_basic
=== CONT  TestAccAWSDBInstance_NoNationalCharacterSet_Oracle
=== CONT  TestAccAWSDBInstance_NationalCharacterSet_Oracle
--- PASS: TestAccAWSDBInstance_basic (449.86s)
--- PASS: TestAccAWSDBInstance_NoNationalCharacterSet_Oracle (792.25s)
--- PASS: TestAccAWSDBInstance_NationalCharacterSet_Oracle (856.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	859.961s

@ewbankkit ewbankkit merged commit 32fe8c9 into hashicorp:main Aug 4, 2021
@github-actions github-actions bot added this to the v3.53.0 milestone Aug 4, 2021
@fergoid fergoid deleted the oracle-only-national-character-set branch August 4, 2021 20:37
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unicode Support For Oracle RDS databases in the provider
2 participants